Skip to content

Fix IsDroppping typo #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koculu merged 1 commit into from
Jun 14, 2025
Merged

Fix IsDroppping typo #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ZoneTree/Segments/Disk/DiskSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public abstract class DiskSegment<TKey, TValue> : IDiskSegment<TKey, TValue>

volatile bool IsDropRequested;

protected volatile bool IsDroppping;
protected volatile bool IsDropping;

bool IsDropped;

Expand Down Expand Up @@ -317,7 +317,7 @@ public void Drop()

// reads will increase ReadCount when they begin,
// and decrease ReadCount when they end.
IsDroppping = true;
IsDropping = true;
// After the flag change,
// reads will start throwing DiskSegmentIsDroppingException

Expand Down
4 changes: 2 additions & 2 deletions src/ZoneTree/Segments/DiskSegmentVariations/FixedSizeKeyAndValueDiskSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ protected override TKey ReadKey(long index, BlockPin blockPin)
{
if (CircularKeyCache.TryGet(index, out var key)) return key;
Interlocked.Increment(ref ReadCount);
if (IsDroppping)
if (IsDropping)
{
throw new DiskSegmentIsDroppingException();
}
Expand All @@ -158,7 +158,7 @@ protected override TValue ReadValue(long index, BlockPin blockPin)
{
if (CircularValueCache.TryGet(index, out var value)) return value;
Interlocked.Increment(ref ReadCount);
if (IsDroppping)
if (IsDropping)
{
throw new DiskSegmentIsDroppingException();
}
Expand Down
4 changes: 2 additions & 2 deletions src/ZoneTree/Segments/DiskSegmentVariations/FixedSizeKeyDiskSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ protected unsafe override TKey ReadKey(long index, BlockPin blockPin)
{
if (CircularKeyCache.TryGet(index, out var key)) return key;
Interlocked.Increment(ref ReadCount);
if (IsDroppping)
if (IsDropping)
{
throw new DiskSegmentIsDroppingException();
}
Expand All @@ -178,7 +178,7 @@ protected unsafe override TValue ReadValue(long index, BlockPin blockPin)
{
if (CircularValueCache.TryGet(index, out var value)) return value;
Interlocked.Increment(ref ReadCount);
if (IsDroppping)
if (IsDropping)
{
throw new DiskSegmentIsDroppingException();
}
Expand Down
4 changes: 2 additions & 2 deletions src/ZoneTree/Segments/DiskSegmentVariations/FixedSizeValueDiskSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,13 @@
sparseArrayDevice.Close();
}

protected unsafe override TKey ReadKey(long index, BlockPin blockPin)

Check warning on line 147 in src/ZoneTree/Segments/DiskSegmentVariations/FixedSizeValueDiskSegment.cs

View workflow job for this annotation

GitHub Actions / build 

In member TKey FixedSizeValueDiskSegment<TKey, TValue>.ReadKey(long index, BlockPin blockPin), change parameter name blockPin to pin in order to match the identifier as it has been declared in TKey DiskSegment<TKey, TValue>.ReadKey(long index, BlockPin pin) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
{
try
{
if (CircularKeyCache.TryGet(index, out var key)) return key;
Interlocked.Increment(ref ReadCount);
if (IsDroppping)
if (IsDropping)
{
throw new DiskSegmentIsDroppingException();
}
Expand Down Expand Up @@ -184,7 +184,7 @@
{
if (CircularValueCache.TryGet(index, out var value)) return value;
Interlocked.Increment(ref ReadCount);
if (IsDroppping)
if (IsDropping)
{
throw new DiskSegmentIsDroppingException();
}
Expand Down
4 changes: 2 additions & 2 deletions src/ZoneTree/Segments/DiskSegmentVariations/VariableSizeDiskSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,13 @@
sparseArrayDevice.Close();
}

protected unsafe override TKey ReadKey(long index, BlockPin blockPin)

Check warning on line 153 in src/ZoneTree/Segments/DiskSegmentVariations/VariableSizeDiskSegment.cs

View workflow job for this annotation

GitHub Actions / build 

In member TKey VariableSizeDiskSegment<TKey, TValue>.ReadKey(long index, BlockPin blockPin), change parameter name blockPin to pin in order to match the identifier as it has been declared in TKey DiskSegment<TKey, TValue>.ReadKey(long index, BlockPin pin) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
{
try
{
if (CircularKeyCache.TryGet(index, out var key)) return key;
Interlocked.Increment(ref ReadCount);
if (IsDroppping)
if (IsDropping)
{
throw new DiskSegmentIsDroppingException();
}
Expand All @@ -183,13 +183,13 @@
}
}

protected unsafe override TValue ReadValue(long index, BlockPin blockPin)

Check warning on line 186 in src/ZoneTree/Segments/DiskSegmentVariations/VariableSizeDiskSegment.cs

View workflow job for this annotation

GitHub Actions / build 

In member TValue VariableSizeDiskSegment<TKey, TValue>.ReadValue(long index, BlockPin blockPin), change parameter name blockPin to pin in order to match the identifier as it has been declared in TValue DiskSegment<TKey, TValue>.ReadValue(long index, BlockPin pin) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
{
try
{
if (CircularValueCache.TryGet(index, out var value)) return value;
Interlocked.Increment(ref ReadCount);
if (IsDroppping)
if (IsDropping)
{
throw new DiskSegmentIsDroppingException();
}
Expand Down
Loading