Add Azure ACS bounce webhooks and settings support#3001
Open
oskari wants to merge 1 commit intoknadh:masterfrom
Open
Add Azure ACS bounce webhooks and settings support#3001oskari wants to merge 1 commit intoknadh:masterfrom
oskari wants to merge 1 commit intoknadh:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Issues Found
No issues found.
Summary
Total issues: 0 critical, 0 important, 0 minor.
Overall Verdict
Status: Patch is correct
Explanation: Reviewed the diff-only changes for Azure ACS bounce webhooks, settings wiring, Message-ID generation/parsing, and the DB migration. No concrete production bugs were found in the introduced logic; the settings/migration/UI paths appear consistent and the webhook handler correctly distinguishes Event Grid validation vs notifications.
Review generated by Hodor (model: gpt-5.2)
Review Metrics — 26 turns, 25 tool calls, 5m 11s
- Tokens: in
20.3K| cached349.8K| out16.9K(total386.9K) - Cost:
$0.3327
Contributor
Author
|
Just to document, this solves #2580 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure ACS is not the most sophisticated platform, but I managed to make it work. Azure documentation around this is a bit lacking (especially Message-ID -> internetMessageId part) but at least on my tests this is working.
Anything I should do differently here or anything that I should clarify?