Fixs #2987 - Prevent confirmed subscriber becoming unconfirmed when re-subscribing.

[blu3id]

This closes #2987 or at least fixes the fix of the regression identified in #2976

A confirmed double opt-in subscriber is no-longer unsubscribed if they re-subscribe to the list (while still subscribed and confirmed).

This doesn't address the discussion point of not leaking information about subscriber status as a confirmed subscriber on a double opt-in list will now get the message "Subscribed successfully." rather than "An e-mail has been sent to you to confirm your subscription(s)." to avoid leaking information about subscription status".

However this was how things have always been and would be a larger piece of work/ restructuring. A work around is adjusting the messages in the i18n language file to remove the difference between the messages.

[github-actions]

Issues Found

Minor (P3)

• [P3] Update comment to match confirmed-status override behavior (queries/subscribers.sql:191-194)
  • The comment says $11 (allow resubscribe) overrides existing statuses, but the newly moved confirmed branch now takes precedence even when $11 = TRUE, meaning confirmed subscriptions are not overridden; this mismatch can mislead future changes around subscription state transitions.

Summary

Total issues: 0 critical, 0 important, 1 minor.

Overall Verdict

Status: Patch is correct

Explanation: The reordered CASE branch correctly preserves an existing confirmed subscription when a user re-subscribes via the public form with allow resubscribe enabled, preventing an unintended downgrade to unconfirmed. No functional regressions are evident in the diff, aside from a now-misleading comment.

---

Review generated by Hodor (model: gpt-5.2)

Review Metrics — 8 turns, 7 tool calls, 57s

• Tokens: in 6.5K | cached 37.4K | out 2.6K (total 46.5K)
• Cost: $0.0542

[blu3id]

Comment adjusted per review.