WIP : fork jooby:1.6.9 as new modules in killbill-commons#194
Draft
xsalefter wants to merge 4 commits intokillbill:masterfrom
Draft
WIP : fork jooby:1.6.9 as new modules in killbill-commons#194xsalefter wants to merge 4 commits intokillbill:masterfrom
jooby:1.6.9 as new modules in killbill-commons#194xsalefter wants to merge 4 commits intokillbill:masterfrom
Conversation
Phase 1.4-1.6 of Jooby fork: - Update pom.xml with managed dependency versions - Add spotbugs-exclude.xml to suppress all upstream SpotBugs findings - Add RAT exclusions for resource files and java-excluded directory - Configure -Pjooby profile for test compilation and execution - Disable test-compile by default (76 PowerMock-dependent files) - Move 76 test files to src/test/java-excluded/ - Keep original MockUnit.java in java-excluded as migration reference
Phase 1.7.1 - Complete MockUnit rewrite: - Replace EasyMock record-replay with Mockito immediate stubbing - mock()/powerMock() -> Mockito.mock() (inline mock maker handles finals) - mockStatic() -> Mockito.mockStatic() with MockedStatic lifecycle - mockConstructor()/constructor().build() -> pre-mock + deferred mockConstruction - capture()/captured() -> ArgumentCaptor - partialMock() -> Mockito.mock(CALLS_REAL_METHODS) - Add mockito-core test dependency (5.3.1, managed by parent)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| //.compile("\\?|/\\*\\*|\\*|\\:((?:[^/]+)+?) |\\{((?:\\{[^/]+?\\}|[^/{}]|\\\\[{}])+?)\\}"); | ||
| /** ? | **:name | * | :var | */ | ||
| .compile( | ||
| "\\?|/\\*\\*(\\:(?:[^/]+))?|\\*|\\:((?:[^/]+)+?)|\\{((?:\\{[^/]+?\\}|[^/{}]|\\\\[{}])+?)\\}"); |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
Comment on lines
+42
to
+44
| "-+BEGIN\\s+.*CERTIFICATE[^-]*-+(?:\\s|\\r|\\n)+" + // Header | ||
| "([a-z0-9+/=\\r\\n]+)" + // Base64 text | ||
| "-+END\\s+.*CERTIFICATE[^-]*-+", // Footer |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
Comment on lines
+47
to
+49
| "-+BEGIN\\s+.*PRIVATE\\s+KEY[^-]*-+(?:\\s|\\r|\\n)+" + // Header | ||
| "([a-z0-9+/=\\r\\n]+)" + // Base64 text | ||
| "-+END\\s+.*PRIVATE\\s+KEY[^-]*-+", // Footer |
Check failure
Code scanning / CodeQL
Inefficient regular expression High
| public void send(final byte[] bytes) throws Exception { | ||
| rsp.setHeader("Transfer-Encoding", null); | ||
| ServletOutputStream output = rsp.getOutputStream(); | ||
| output.write(bytes); |
Check warning
Code scanning / CodeQL
Cross-site scripting Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP.