fix: Check gzip log via magic numbers#1891
Open
alanpeixinho wants to merge 1 commit into
Open
Conversation
* We are directly checking the bytes content of the log.
If, for any reason, the content is not compressed, or is compressed
but with wrong file extension, we are still going to properly
decompress the file content.
Closes kernelci#1887
alanpeixinho
force-pushed
the
fix/check-logviewer-decompression
branch
from
f92b72a to
7634bf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are directly checking the bytes content of the log. If, for any reason, the content is not compressed, or is compressed but with wrong file extension, we are still going to properly decompress the file content.
How to test
Check for both cases (compressed and uncompressed) of logs, and verify they behave properly (valid utf-8 characters being rendered).
Examples for both cases:
Closes #1887