Skip to content

Clarify that upload speed metrics are in bits#1886

Open
Frenzie wants to merge 1 commit intokartik-v:masterfrom
Frenzie:bits-and-bytes
Open

Clarify that upload speed metrics are in bits#1886
Frenzie wants to merge 1 commit intokartik-v:masterfrom
Frenzie:bits-and-bytes

Conversation

@Frenzie
Copy link
Copy Markdown

@Frenzie Frenzie commented Oct 30, 2025

Scope

This pull request includes a

  • Bug fix
  • New feature
  • Translation

Changes

The following changes were made

  • Changed MB/s and such to Mbps to clarify that it's actually bits, not bytes

Alternate patch, keep the strings the same and change the displayed value to bytes:

diff --git a/js/fileinput.js b/js/fileinput.js
index 59a0e6b..db5046b 100755
--- a/js/fileinput.js
+++ b/js/fileinput.js
@@ -1192,7 +1192,7 @@
               n = parseFloat(fm.bpsLog[i]);
               j++;
             }
-            fm.bps = (j > 0 ? n / j : 0) * 64;
+            fm.bps = (j > 0 ? n / j : 0) * 8;
           }, delay);
           out = {
             fileId: id,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant