Conversation
…xplicit tests and behavior for empty versus wildcard, restores the benchmark test and addresses the nitpick comments - does not include the performance issue re the zero-alloc Signed-off-by: entlein <einentlein@gmail.com>
Address CodeRabbit's outbound-mutation footgun: the public lookup returned *CollapseConfig pointing into ua.configs / ua.defaultCfg, so 'cfg := analyzer.FindConfigForPath(p); cfg.Threshold = 1' silently mutated the analyzer's threshold map for every future call. That defeated the defensive inbound copy NewPathAnalyzerWithConfigs already makes. Switch to value return. The fall-through to defaultCfg is now also a value copy, so callers cannot poison the analyzer through that path either. Doc updated — the old 'or nil if none match' wording was wrong; the function never returned nil, it always falls back to defaultCfg. TestFindConfigForPath_DefensiveCopy pins the contract: mutating the returned config (Threshold and Prefix) does not affect a subsequent call, exercised on both the per-prefix and default-fallback paths. TestFindConfigForPath drops the dead 'NotNil' assertion (a value can't be nil); field reads work unchanged on both pointer and value.
|
Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands the upstream PR kubescape#316 review feedback on fork main. Two cherry-picks:
What's in here
Behavior fixes
Defensive-immutability hardening
CodeRabbit cleanup
Tests pinning the contracts
Out of scope
Test plan