Add nats build tag from KINE for embedded support#8882
Open
bruth wants to merge 1 commit intok3s-io:mainfrom
Open
Add nats build tag from KINE for embedded support#8882bruth wants to merge 1 commit intok3s-io:mainfrom
nats build tag from KINE for embedded support#8882bruth wants to merge 1 commit intok3s-io:mainfrom
Conversation
Signed-off-by: Byron Ruth <byron@nats.io>
|
Hello, is this the only change needed to support embedded nats ? |
Member
|
PR needs a rebase, but yeah I think so. |
|
@bruth could you please rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Support embedded NATS by default.
Types of Changes
It will embed the NATS server as part of the k3s binary rather than require an external server.
Verification
NATS is already embedded within standalone KINE releases.
Testing
Current testing is done within KINE.
Linked Issues
User-Facing Change
For existing deployments of k3s that used NATS (implying an external server/cluster), the
--datastore-endpoint=nats://...CLI option must be updated with thenoEmbedparam to prevent running in embedded mode and expect to connect to an external server.Further Comments
None.