Skip to content

build(deps): bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.1.4 in /controller#410

Closed
dependabot[bot] wants to merge 2 commits intomainfrom
dependabot/go_modules/controller/github.com/go-jose/go-jose/v4-4.1.4
Closed

build(deps): bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.1.4 in /controller#410
dependabot[bot] wants to merge 2 commits intomainfrom
dependabot/go_modules/controller/github.com/go-jose/go-jose/v4-4.1.4

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Apr 7, 2026

Bumps github.com/go-jose/go-jose/v4 from 4.0.4 to 4.1.4.

Release notes

Sourced from github.com/go-jose/go-jose/v4's releases.

v4.1.4

What's Changed

Fixes Panic in JWE decryption. See GHSA-78h2-9frx-2jm8

Full Changelog: go-jose/go-jose@v4.1.3...v4.1.4

v4.1.3

This release drops Go 1.23 support as that Go release is no longer supported. With that, we can drop x/crypto and no longer have any external dependencies in go-jose outside of the standard library!

This release fixes a bug where a critical b64 header was ignored if in an unprotected header. It is now rejected instead of ignored.

What's Changed

Full Changelog: go-jose/go-jose@v4.1.2...v4.1.3

v4.1.2

What's Changed

go-jose v4.1.2 improves some documentation, errors, and removes the only 3rd-party dependency.

New Contributors

Full Changelog: go-jose/go-jose@v4.1.1...v4.1.2

v4.1.1

What's Changed

New Contributors

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update go code minor labels Apr 7, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c9dd118c-806b-44fe-8302-bd466acebd92

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/go_modules/controller/github.com/go-jose/go-jose/v4-4.1.4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 7, 2026

Deploy Preview for jumpstarter-docs ready!

Name Link
🔨 Latest commit a6b4e1b
🔍 Latest deploy log https://app.netlify.com/projects/jumpstarter-docs/deploys/69d663731827140009c6f48b
😎 Deploy Preview https://deploy-preview-410--jumpstarter-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ambient-code
Copy link
Copy Markdown
Contributor

ambient-code bot commented Apr 7, 2026

Fix Applied

Dependabot only updated controller/go.mod but missed controller/deploy/operator/go.mod, which also depends on go-jose/go-jose/v4 (was at v4.1.1). Since the operator module has a replace directive pointing to the controller (replace github.com/jumpstarter-dev/jumpstarter-controller => ../../), both modules need compatible dependencies.

CI was failing with:

go: updates to go.mod needed; to update it:
    go mod tidy

I've pushed a commit that runs go mod tidy in controller/deploy/operator/ to sync the go-jose dependency (v4.1.1 → v4.1.4) and ran go fmt in both subprojects. CI should pass now.

@ambient-code
Copy link
Copy Markdown
Contributor

ambient-code bot commented Apr 7, 2026

E2E Test Flakiness

The remaining CI failures (e2e-tests (ubuntu-24.04, helm) and the cancelled operator/arm runs) are flaky tests, not caused by the go-jose bump. Tests 47 and 48 ("can lease and connect to exporters" / "can lease and connect to exporters by name") fail with Error: Connection to exporter lost — the same error seen on completely unrelated branches (e.g. driver-mitmproxy). All core checks (lint-go, tests, deploy-kind, e2e-test-operator, compat tests) pass.

This PR looks good to merge — the dependency bump and operator submodule sync are correct. The e2e flake should be investigated separately.

Note: this go-jose bump includes a security fix (GHSA-78h2-9frx-2jm8 — panic in JWE decryption), so merging is recommended.

@ambient-code
Copy link
Copy Markdown
Contributor

ambient-code bot commented Apr 7, 2026

Dependabot PR Analysis

CI Status

The e2e-tests (ubuntu-24.04, helm) failure is a flaky test — not caused by this dependency change. Tests 47 & 48 ("can lease and connect to exporters" / "can lease and connect to exporters by name") fail with Connection to exporter lost, which is a known race condition in listenQueues cleanup. The same failure is happening on multiple unrelated PRs today. PR #417 (fix-listen-queue-race) addresses the root cause.

All other tests pass, including lint-go, tests, deploy-kind, and e2e-compat-*.

Dependency Analysis

This PR bumps github.com/go-jose/go-jose/v4 from v4.0.4 to v4.1.4 in /controller. It correctly updates both controller/go.mod and controller/deploy/operator/go.mod. This is a focused, clean bump with minimal transitive changes.

Security motivation: v4.1.4 fixes GHSA-78h2-9frx-2jm8 — a panic in JWE decryption. This is worth merging.

⚠️ Note: PR #413 (grpc bump) also pulls in go-jose v4.1.3 as a transitive dependency. These PRs may conflict if merged in certain orders, but merging this one first is cleaner.

🤖 Generated with Claude Code

@ambient-code
Copy link
Copy Markdown
Contributor

ambient-code bot commented Apr 7, 2026

Automated Dependabot PR Review

Checks performed:

1. go.mod completeness: ✅ This PR correctly updates both controller/go.mod and controller/deploy/operator/go.mod — no other go sub-projects in the tree need updates.

2. CI status: ⚠️ The e2e tests (tests 47-48: "can lease and connect to exporters") failed, but this is a flaky infrastructure issue (connection refused / timeout on grpc dial), not related to this dependency change. The same tests fail on unrelated PRs (e.g. #409), and main branch e2e tests all pass consistently.

3. K8s version check: N/A — this is not a k8s dependency bump.

4. Library assessment: This is a security-relevant update. go-jose v4.1.4 fixes:

  • GHSA-78h2-9frx-2jm8: Panic in JWE decryption (v4.1.4)
  • Rejects JWS with unprotected critical b64 header (v4.1.3)
  • Improved error messages and removed external dependencies (v4.1.1-v4.1.2)

No breaking API changes — this is a safe minor version bump with security fixes. Recommended to merge.

@ambient-code
Copy link
Copy Markdown
Contributor

ambient-code bot commented Apr 7, 2026

@dependabot rebase

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Apr 7, 2026

Sorry, only users with push access can use that command.

@ambient-code ambient-code bot force-pushed the dependabot/go_modules/controller/github.com/go-jose/go-jose/v4-4.1.4 branch from 3b3b50b to ae10c66 Compare April 7, 2026 13:19
@mangelajo
Copy link
Copy Markdown
Member

@ambient-code please rebase this

dependabot bot and others added 2 commits April 8, 2026 14:17
Bumps [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose) from 4.0.4 to 4.1.4.
- [Release notes](https://github.com/go-jose/go-jose/releases)
- [Commits](go-jose/go-jose@v4.0.4...v4.1.4)

---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v4
  dependency-version: 4.1.4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…troller

Run go mod tidy in controller/deploy/operator to sync the go-jose dependency
bump (v4.0.4 → v4.1.4) from controller/go.mod into the operator submodule.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ambient-code ambient-code bot force-pushed the dependabot/go_modules/controller/github.com/go-jose/go-jose/v4-4.1.4 branch from ae10c66 to a6b4e1b Compare April 8, 2026 14:17
@mangelajo mangelajo closed this Apr 9, 2026
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Apr 9, 2026

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/controller/github.com/go-jose/go-jose/v4-4.1.4 branch April 9, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

already-checked dependencies Pull requests that update a dependency file go Pull requests that update go code minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant