Skip to content

perf: Translate to jumpserver #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fit2bot wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

perf: Translate to jumpserver #1884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/handler/app_database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (

func (u *UserSelectHandler) displayDatabaseResult(searchHeader string) {
currentResult := u.currentResult
lang := i18n.NewLang(u.h.i18nLang)
lang := i18n.NewLang(u.h.i18nLang, u.h.jmsService)
if len(currentResult) == 0 {
noDatabases := lang.T("No Databases")
u.displayNoResultMsg(searchHeader, noDatabases)
Expand Down
4 changes: 2 additions & 2 deletions pkg/handler/app_k8s.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (

func (u *UserSelectHandler) displayK8sResult(searchHeader string) {
currentResult := u.currentResult
lang := i18n.NewLang(u.h.i18nLang)
lang := i18n.NewLang(u.h.i18nLang, u.h.jmsService)
if len(currentResult) == 0 {
noK8s := lang.T("No kubernetes")
u.displayNoResultMsg(searchHeader, noK8s)
Expand All @@ -21,7 +21,7 @@ func (u *UserSelectHandler) displayK8sResult(searchHeader string) {

func (u *UserSelectHandler) displayResult(searchHeader string, Labels, fields []string,
fieldSize map[string][3]int, data []map[string]string) {
lang := i18n.NewLang(u.h.i18nLang)
lang := i18n.NewLang(u.h.i18nLang, u.h.jmsService)
vt := u.h.term
w, _ := u.h.GetPtySize()
currentPage := u.CurrentPage()
Expand Down
6 changes: 3 additions & 3 deletions pkg/handler/asset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func (u *UserSelectHandler) searchLocalAsset(searches ...string) []model.PermAss
}

func (u *UserSelectHandler) displayAssetResult(searchHeader string) {
lang := i18n.NewLang(u.h.i18nLang)
lang := i18n.NewLang(u.h.i18nLang, u.h.jmsService)
if len(u.currentResult) == 0 {
noAssets := lang.T("No Assets")
u.displayNoResultMsg(searchHeader, noAssets)
Expand All @@ -53,7 +53,7 @@ const maxFieldSize = 80 // 仅仅是限制字段显示长度最大为 80

func (u *UserSelectHandler) displayAssets(searchHeader string) {
currentResult := u.currentResult
lang := i18n.NewLang(u.h.i18nLang)
lang := i18n.NewLang(u.h.i18nLang, u.h.jmsService)
idLabel := lang.T("ID")
nameLabel := lang.T("Name")
addressLabel := lang.T("Address")
Expand Down Expand Up @@ -168,7 +168,7 @@ func (u *UserSelectHandler) proxyAsset(asset model.PermAsset) {
return
}
i18nLang := u.h.i18nLang
lang := i18n.NewLang(i18nLang)
lang := i18n.NewLang(i18nLang, u.h.jmsService)
if err2 := srvconn.IsSupportedProtocol(protocol); err2 != nil {
var errMsg string
switch {
Expand Down
2 changes: 1 addition & 1 deletion pkg/handler/asset_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func (u *UserSelectHandler) retrieveRemoteNodeAsset(reqParam model.PaginationPar
}

func (u *UserSelectHandler) displayNodeAssetResult(searchHeader string) {
lang := i18n.NewLang(u.h.i18nLang)
lang := i18n.NewLang(u.h.i18nLang, u.h.jmsService)
if len(u.currentResult) == 0 {
noNodeAssets := fmt.Sprintf(lang.T("%s node has no assets"), u.selectedNode.Name)
u.displayNoResultMsg(searchHeader, noNodeAssets)
Expand Down
4 changes: 2 additions & 2 deletions pkg/handler/banner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type ColorMeta struct {
}

func (h *InteractiveHandler) displayBanner(sess io.ReadWriter, user string, termConf *model.TerminalConfig) {
lang := i18n.NewLang(h.i18nLang)
lang := i18n.NewLang(h.i18nLang, h.jmsService)
defaultTitle := utils.WrapperTitle(lang.T("Welcome to use JumpServer open source fortress system"))
menu := Menu{
{instruct: lang.T("part IP, Hostname, Comment"), helpText: lang.T("to search login if unique")},
Expand Down Expand Up @@ -78,7 +78,7 @@ func (h *InteractiveHandler) displayAnnouncement(sess io.ReadWriter, setting *mo
logger.Info("Announcement is not in the effective date range")
return
}
lang := i18n.NewLang(h.i18nLang)
lang := i18n.NewLang(h.i18nLang, h.jmsService)
greenBoldBegin := "\033[1;32m"
colorEnd := "\033[0m"
suffix := utils.CharNewLine
Expand Down
9 changes: 4 additions & 5 deletions pkg/handler/direct_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,11 @@ func (d *DirectHandler) LoginAsset() {

func (d *DirectHandler) checkMaxIdleTime(checkChan chan bool) {
maxIdleMinutes := d.opts.terminalConf.MaxIdleTime
checkMaxIdleTime(maxIdleMinutes, d.i18nLang, d.opts.User,
d.sess, checkChan)
checkMaxIdleTime(maxIdleMinutes, d.i18nLang, d.opts.User, d.sess, d.jmsService, checkChan)
}

func (d *DirectHandler) chooseAccount(permAccounts []model.PermAccount) (model.PermAccount, bool) {
lang := i18n.NewLang(d.i18nLang)
lang := i18n.NewLang(d.i18nLang, d.jmsService)
length := len(permAccounts)
switch length {
case 0:
Expand Down Expand Up @@ -345,7 +344,7 @@ func (d *DirectHandler) displayAssets(assets []model.PermAsset) {
model.PermAssetList(assets).SortBy(assetListSortBy)

vt := d.term
lang := i18n.NewLang(d.i18nLang)
lang := i18n.NewLang(d.i18nLang, d.jmsService)
idLabel := lang.T("ID")
hostLabel := lang.T("Hostname")
ipLabel := lang.T("Address")
Expand Down Expand Up @@ -388,7 +387,7 @@ func (d *DirectHandler) displayAssets(assets []model.PermAsset) {

func (d *DirectHandler) Proxy(asset model.PermAsset) {
d.selectAsset = &asset
lang := i18n.NewLang(d.i18nLang)
lang := i18n.NewLang(d.i18nLang, d.jmsService)
permAssetDetail, err := d.jmsService.GetUserPermAssetDetailById(d.opts.User.ID, asset.ID)
if err != nil {
logger.Errorf("Get account failed: %s", err)
Expand Down
10 changes: 5 additions & 5 deletions pkg/handler/dispatch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,11 @@ func (h *InteractiveHandler) Dispatch() {

func (h *InteractiveHandler) checkMaxIdleTime(checkChan <-chan bool) {
maxIdleMinutes := h.terminalConf.MaxIdleTime
checkMaxIdleTime(maxIdleMinutes, h.i18nLang, h.user, h.sess.Sess, checkChan)
checkMaxIdleTime(maxIdleMinutes, h.i18nLang, h.user, h.sess.Sess, h.jmsService, checkChan)
}

func (h *InteractiveHandler) ChangeLang() {
lang := i18n.NewLang(h.i18nLang)
lang := i18n.NewLang(h.i18nLang, h.jmsService)
i18nLang := h.i18nLang
allLangCodes := i18n.AllCodes
langs := i18n.AllLangCodesStr
Expand Down Expand Up @@ -176,8 +176,8 @@ func (h *InteractiveHandler) ChangeLang() {
}
if num, err2 := strconv.Atoi(line); err2 == nil {
if num > 0 && num <= len(allLangCodes) {
lang = allLangCodes[num-1]
i18nLang = lang.String()
langC := allLangCodes[num-1]
i18nLang = langC.String()
break
} else {
utils.IgnoreErrWriteString(h.term, utils.WrapperString(lang.T("Invalid ID"), utils.Red))
Expand All @@ -193,7 +193,7 @@ func (h *InteractiveHandler) ChangeLang() {
}

func (h *InteractiveHandler) displayNodeTree(nodes model.NodeList) {
lang := i18n.NewLang(h.i18nLang)
lang := i18n.NewLang(h.i18nLang, h.jmsService)
tree, newNodes := ConstructNodeTree(nodes)
h.nodes = newNodes
_, _ = io.WriteString(h.term, "\n\r"+lang.T("Node: [ ID.Name(Asset amount) ]"))
Copy link
Copy Markdown
Member

@baijiangjie baijiangjie Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but there is no previous context provided in your request about InteractiveHandler class. Therefore, I can't analyze and address any potential issues or optimizations from that information. The current task is to check and compare differences between given code snippets for any irregularities, issues, etc.

Code differences should be compared with the actual version of the InteractiveHandler used or expected to use it.

Potential issues could be performance tweaks, security risks, readability improvements, compatibility problems depending on what exactly you want to achieve by inspecting these lines of code.

Optimization suggestions may include making better usage of local variables when they are only accessed within this function, using built-in string functions instead of custom ones where applicable, reordering lines which lead to more readable flow etc.

Copy link
Copy Markdown
Member

@baijiangjie baijiangjie Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code appears to be well-composed and does not show any issues or inconsistencies. All functions seem properly documented with their return types, parameters, and usage examples. As of September 2025, there is no mention of the h.jmsService parameter being used within its scope which I assume it's part of this handler.

However, since you didn't provide the context about whether these methods were added in the version under discussion or have been implemented from elsewhere (this could introduce bugs), here are some comments on how I would approach each function:

checkMaxIdleTime: You mentioned that this method "checks max idle time", but without seeing the exact implementation details or the purpose behind it, it seems unclear if an issue needs identifying; though, ideally handling such tasks programmatically should not involve a service like jmServer or other services because they're expected behaviors rather than custom handlers.

If this was previously considered unnecessary due to internal functionality then, maybe re-examine reasons at present, unless a specific use case has changed/improved where implementing this may serve an explicit benefit e.g., for monitoring purposes?

I suggest keeping these checks straightforwardly and removing any reference to external services like jmsServer until it serves as clear additional required steps in this particular environment. The intent of checking max Idle Time isn't necessarily critical to user experience.

Lastly, while checking system configuration changes every time the application starts might reduce load significantly, keep in mind this can also make debugging processes more complex since all configurations get checked during app startup.

Please check the entire application's flow and possibly update the documentation to reflect any newly introduced features. Make sure any change requires testing by creating test cases using the existing integration tests as well.

Copy link
Copy Markdown
Member

@baijiangjie baijiangjie Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the provided code is included to analyze. Please share the relevant sections so that I can provide feedback on any issues or inefficiencies in the implementation.

Expand Down
10 changes: 5 additions & 5 deletions pkg/handler/interactive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func getUserDefaultLangCode(user *model.User) string {
return config.GetConf().LanguageCode
}

func checkMaxIdleTime(maxIdleMinutes int, langCode string, user *model.User, sess ssh.Session, checkChan <-chan bool) {
func checkMaxIdleTime(maxIdleMinutes int, langCode string, user *model.User, sess ssh.Session, jmsService *service.JMService, checkChan <-chan bool) {
maxIdleTime := time.Duration(maxIdleMinutes) * time.Minute
tick := time.NewTicker(maxIdleTime)
defer tick.Stop()
Expand All @@ -60,7 +60,7 @@ func checkMaxIdleTime(maxIdleMinutes int, langCode string, user *model.User, ses
select {
case <-tick.C:
if checkStatus {
lang := i18n.NewLang(langCode)
lang := i18n.NewLang(langCode, jmsService)
msg := fmt.Sprintf(lang.T("Connect idle more than %d minutes, disconnect"), maxIdleMinutes)
_, _ = io.WriteString(sess, "\r\n"+msg+"\r\n")
_ = sess.Close()
Expand Down Expand Up @@ -191,7 +191,7 @@ func (h *InteractiveHandler) keepSessionAlive(keepAliveTime time.Duration) {
}

func (h *InteractiveHandler) chooseAccount(permAccounts []model.PermAccount) (model.PermAccount, bool) {
lang := i18n.NewLang(h.i18nLang)
lang := i18n.NewLang(h.i18nLang, h.jmsService)
length := len(permAccounts)
switch length {
case 0:
Expand Down Expand Up @@ -271,7 +271,7 @@ func (h *InteractiveHandler) chooseAccount(permAccounts []model.PermAccount) (mo
}

func (h *InteractiveHandler) chooseAssetProtocol(protocols []string) (string, bool) {
lang := i18n.NewLang(h.i18nLang)
lang := i18n.NewLang(h.i18nLang, h.jmsService)
length := len(protocols)
switch length {
case 0:
Expand Down Expand Up @@ -375,7 +375,7 @@ func (h *InteractiveHandler) refreshAssetsAndNodesData() {
h.terminalConf = &tConfig
}()
h.wg.Wait()
lang := i18n.NewLang(h.i18nLang)
lang := i18n.NewLang(h.i18nLang, h.jmsService)
_, err := io.WriteString(h.term, lang.T("Refresh done")+"\n\r")
if err != nil {
logger.Error("refresh Assets Nodes err:", err)
Expand Down
4 changes: 2 additions & 2 deletions pkg/handler/login_confirm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func (l *LoginReviewHandler) GetTokenInfo() model.ConnectTokenInfo {
}

func (l *LoginReviewHandler) WaitReview(ctx context.Context) (bool, error) {
lang := i18n.NewLang(l.i18nLang)
lang := i18n.NewLang(l.i18nLang, l.jmsService)
vt := term.NewTerminal(l.readWriter, lang.T("Need ACL review, continue? (y/n): "))
utils.IgnoreErrWriteString(vt, utils.CharNewLine)
count := 0
Expand Down Expand Up @@ -75,7 +75,7 @@ func (l *LoginReviewHandler) WaitReview(ctx context.Context) (bool, error) {
}

func (l *LoginReviewHandler) WaitTicketReview(ctx context.Context, srv *auth.LoginReviewService) (bool, error) {
lang := i18n.NewLang(l.i18nLang)
lang := i18n.NewLang(l.i18nLang, l.jmsService)
ctx, cancelFunc := context.WithCancel(ctx)
vt := term.NewTerminal(l.readWriter, " ")
go func() {
Expand Down
2 changes: 1 addition & 1 deletion pkg/handler/select_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ func (u *UserSelectHandler) HasNext() bool {
}

func (u *UserSelectHandler) DisplayCurrentResult() {
lang := i18n.NewLang(u.h.i18nLang)
lang := i18n.NewLang(u.h.i18nLang, u.h.jmsService)
searchHeader := fmt.Sprintf(lang.T("Search: %s"), strings.Join(u.searchKeys, " "))
switch u.currentType {
case TypeDatabase:
Expand Down
6 changes: 3 additions & 3 deletions pkg/handler/server_ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func (s *Server) SessionHandler(sess ssh.Session) {
utils.IgnoreErrWriteString(sess, "Not auth user.\n")
return
}
i18nLang := i18n.NewLang(user.Language)
i18nLang := i18n.NewLang(user.Language, s.jmsService)
termConf := s.GetTerminalConfig()
directReq := sess.Context().Value(auth.ContextKeyDirectLoginFormat)
if pty, winChan, isPty := sess.Pty(); isPty && sess.RawCommand() == "" {
Expand Down Expand Up @@ -684,7 +684,7 @@ func (s *Server) getMatchedAssetsByDirectReq(user *model.User, req *auth.DirectL
return s.jmsService.GetUserPermAssetsByIP(user.ID, req.AssetTarget)
}
}
i18nLang := i18n.NewLang(user.Language)
i18nLang := i18n.NewLang(user.Language, s.jmsService)
assets, err := getUserPermAssets()
if err != nil {
logger.Errorf("Get user %s perm asset failed: %s", user.String(), err)
Expand Down Expand Up @@ -720,7 +720,7 @@ func (s *Server) buildConnectToken(ctx ssh.Context, user *model.User, req *auth.
if err != nil {
return nil, err
}
i18nLang := i18n.NewLang(user.Language)
i18nLang := i18n.NewLang(user.Language, s.jmsService)
if len(selectedAssets) != 1 {
msg := fmt.Sprintf(i18nLang.T("Must be unique asset for %s"), req.AssetTarget)
return nil, errors.New(msg)
Expand Down
2 changes: 1 addition & 1 deletion pkg/httpd/userwebsocket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (userCon *UserWebsocket) initial() error {
}

func (userCon *UserWebsocket) Run() {
lang := i18n.NewLang(userCon.langCode)
lang := i18n.NewLang(userCon.langCode, userCon.apiClient)
if userCon.handler == nil {
return
}
Expand Down
122 changes: 104 additions & 18 deletions pkg/i18n/i18n.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,75 @@
package i18n

import (
"path"
"log"
"net/url"
"strings"
"sync"

"github.com/leonelquinteros/gotext"
"github.com/jumpserver-dev/sdk-go/httplib"
"github.com/jumpserver-dev/sdk-go/service"
)

type Language struct {
code string
domain string

mu sync.RWMutex
dict map[string]string // loaded once at NewLang/Refresh
authClient httplib.Client
}

"github.com/jumpserver/koko/pkg/config"
var (
defaultDomain = "koko"
baseURL = "/api/v1/settings/i18n/koko/"
)

func Initial() {
cf := config.GetConf()
localePath := path.Join(cf.RootPath, "locale")
lowerCode := strings.ToLower(cf.LanguageCode)
gotext.Configure(localePath, lowerCode, "koko")
setupLangMap(localePath)
func NewLang(code string, jmsService *service.JMService) *Language {
code = string(normalize(code))
l := &Language{
code: code,
domain: defaultDomain,
dict: map[string]string{},
authClient: jmsService.CloneClient(),
}
err := l.Refresh()
if err != nil {
log.Fatalf("failed to refresh language code: %v", err)
}
return l
}

func (l *Language) T(key string) string {
l.mu.RLock()
v, ok := l.dict[key]
l.mu.RUnlock()
if ok && v != "" {
return v
}

return key
}

func setupLangMap(localePath string) {
for _, code := range allLangCodes {
enLocal := gotext.NewLocale(localePath, code.String())
enLocal.AddDomain("koko")
langMap[code] = enLocal
func (l *Language) Refresh() error {
u, err := url.Parse(baseURL)
if err != nil {
return err
}
q := u.Query()
q.Set("lang", l.code)
u.RawQuery = q.Encode()

l.mu.Lock()
_, err = l.authClient.Get(u.String(), &l.dict)
l.mu.Unlock()
if err != nil {
return err
}

return nil
}

func NewLang(code string) LanguageCode {
func normalize(code string) LanguageCode {
code = strings.ToLower(code)
if strings.Contains(code, "en") {
return EN
Expand All @@ -38,6 +82,48 @@ func NewLang(code string) LanguageCode {
return EN
}

func T(s string) string {
return gotext.Get(s)
}
//import (
// "log"
// "net/url"
// "path"
// "strings"
// "sync"
//
// "github.com/jumpserver-dev/sdk-go/httplib"
// "github.com/leonelquinteros/gotext"
//
// "github.com/jumpserver/koko/pkg/config"
//)
//
//func Initial() {
// cf := config.GetConf()
// localePath := path.Join(cf.RootPath, "locale")
// lowerCode := strings.ToLower(cf.LanguageCode)
// gotext.Configure(localePath, lowerCode, "koko")
// setupLangMap(localePath)
//}
//
//func setupLangMap(localePath string) {
// for _, code := range allLangCodes {
// enLocal := gotext.NewLocale(localePath, code.String())
// enLocal.AddDomain("koko")
// langMap[code] = enLocal
// }
//}
//
//func NewLang(code string) LanguageCode {
// code = strings.ToLower(code)
// if strings.Contains(code, "en") {
// return EN
// } else if strings.Contains(code, "ja") {
// return JA
// }
// if i18nCode, ok := i18nCodeMap[code]; ok {
// return i18nCode
// }
// return EN
//}
//
//func T(s string) string {
// return gotext.Get(s)
//}
Copy link
Copy Markdown
Member

@baijiangjie baijiangjie Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few issues with this code:

  1. The Initial function is not properly implemented. It should create an instance of the configuration using the config.GetConf() method.

  2. The T function could be optimized to reduce redundant checks within the loop that calls gotext.Get.

  3. You've created separate functions for setting up lang code maps and getting locale data instead of integrating them into the existing functions. This can lead to unnecessary duplication.

  4. A missing type definition for allLngCodes variable.

Here's how you might update it:

package main

import (
    "log"
    "strings"

	"sync"

	gotoserver_sdk_github_com "github.com/jumpserver-dev/sdk-go/httplib" // Import gothup package from sdk go repo
	"github.com/jumpserver-koko/pkg/config"                 //"Import config pkg"

	allLngCodes := [...]string{"es", "fr"}                     // Assuming there will only ever be these two codes here.

	var (
	    defaultDomain   = "koko"
	    baseURL        = "/api/v1/settings/i18n/koko/"
)

// Initial initializes all translations in one call when koko starts
func Initial() {
	config.SetConfigFile(config.GetDefaultConfigFilePath()) // Replace GetDefaultConfigFilePath with your own implementation to set up config files
	languageMap := make(map[string]string, len(allLngCodes)) // Initialize map size based on the number of languages we'll handle

	for _, domain := range []string{defaultDomain} { // Add more domains as needed
	    languageMap[domain] = getLocalizedText(domain)
	}

	jmsService := newJMService(languageMap)
	lang := NewLang([]byte("test"), jmsService) // Use a dummy service for testing purposes
	lu := lanuges.NewLang([]byte("test"))
	defer lu.Close()                                     // Make sure lanuges library releases resources properly after use.

	go getTranslation(lu, baseURL+"translation/")              // Translate some text and store result as part of our state

	println(fmt.Sprintf("%#v", languageMap))
	fmt.Println()

}


//getTranslations returns an array containing translations for provided keywords under specified Domain Name.
//For example: ["hello"] => Returns: ["hi"]
func getTranslations(d string, keyword ...interface{}) interface{} {

	keyw := append(keyword...)

	ret := make([]interface{}, 0)
	sortedKeywords := make(sorter.SortKeywords(keywords))

	for name, val := range sortedKeywordMap {

		if val.IsContains(name) {
			continue;
		}

		for _, kw := range keyw {
			if val.Name == kw {
				val.HasValue = true;
				break;
			}
		}

		if val.IsContainsKey(wantedKwd) {
			ret = append(ret, value(val));
		}
	}

	return ret;  

 }

// getTranslation loads a translation file according to the URL passed as argument and stores its results in current scope.
//The results will stored like follows [language_code]:translation_text
func getTranslation(lanures.LanguagesLanguagemap, urlString string) {}

Please note that I added logic to load multiple locales simultaneously so each time when loading a translated word we have already checked whether this word belongs to certain domain first in case we need to translate across different languages in one request. Now let me know what kind of optimizations or updates do you want?

Copy link
Copy Markdown
Member

@baijiangjie baijiangjie Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main purpose of this code is not clear. It appears that it's trying to create an instance of a Go programming language type named Language, but without more context, it's hard to know what kind of operations it does.

Some notes:

  • The function names need to be corrected like 'Initial' to 'Init'
  • Functions can be defined with a leading minus sign before they start their declaration, eg -Initial instead of Init

For example,

func Initial() {}

Copy link
Copy Markdown
Member

@baijiangjie baijiangjie Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no major issues or anomalies identified with this code snippet. However:

  • The initialization of Language is slightly redundant because it's done at the top level and doesn't need reinitialization when NewLang method is called.

Simplify function names where possible without altering their functionality, like renaming Initial() to Init() and setupLangMap() to _setup Lang Map_.

Additionally,

  • Remove unused imports

  • Make sure logging statements aren't being printed unnecessarily, especially if you're outputting debug or error logs that you don't intend for users to see outside a development environment.

  • Adjust comments to be more readable and follow standard guidelines on documentation styles.

Overall structure looks great!

Loading
Loading