Skip to content

Fix error when http module is mock in tests #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ardiadrianadri wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix error when http module is mock in tests #20

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cdf1693
If Http does not has methods declared the default ones are returned
ardiadrianadri Jan 16, 2019
748c799
Check if http.METHODS exists and if it is an array with values
ardiadrianadri Jan 17, 2019
bf999d7
Change const by var for backward compatibility
ardiadrianadri Jan 17, 2019
92d3592
Remove extra semicolon at the end of the lines
ardiadrianadri Jan 17, 2019
130f0fa
Add unit test
ardiadrianadri Jan 19, 2019
07afd63
Remove chai dependencies
ardiadrianadri Jan 19, 2019
bfea662
Fix code styles
ardiadrianadri Jan 19, 2019
0b9479f
Add extra line at the end of the test
ardiadrianadri Jan 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ module.exports = getCurrentNodeMethods() || getBasicNodeMethods()
*/

function getCurrentNodeMethods () {
return http.METHODS && http.METHODS.map(function lowerCaseMethod (method) {
var methods = http.METHODS && http.METHODS.map(function lowerCaseMethod (method) {
return method.toLowerCase()
})

return (methods && methods.length > 0) ? methods : false
}

/**
Expand Down