Update min version of nan dependency to 2.18.0#180
Open
michaelgambold wants to merge 3 commits intojperkin:masterfrom
Open
Update min version of nan dependency to 2.18.0#180michaelgambold wants to merge 3 commits intojperkin:masterfrom
michaelgambold wants to merge 3 commits intojperkin:masterfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update nan dependency to 2.18.0 (latest). Version 2.17.0 is the minimum required to overcome the
AccessorSignaturesissue when using Node 20. Dependencies added with Node 14 to keep old version of package.lock.json.Added CI config for Node 16/18 as by now LTS is probably using version 20 and don't want any regressions with previous versions.
Updated documentation with versions of node supported as I have verified and used this library with these versions.