Replace tiny-emitter package with inline ESM implementation#3653
Open
andreialecu wants to merge 1 commit intojosdejong:developfrom
Open
Replace tiny-emitter package with inline ESM implementation#3653andreialecu wants to merge 1 commit intojosdejong:developfrom
andreialecu wants to merge 1 commit intojosdejong:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tiny-emitterdependency with an inline ESM implementationPart of #3649 — this is the last of the four CommonJS dependencies (
seedrandom,escape-latex,javascript-natural-sort,tiny-emitter).Details
The
tiny-emitterpackage hasn't been updated in 7+ years and only ships CommonJS. Rather than waiting for an upstream ESM build, this inlines the implementation directly into the existingemitter.jswrapper.The new implementation is actually simpler than the original wrapper — instead of creating a
new Emitter()instance and.bind()-ing four methods, theon/off/once/emitmethods are defined directly as closures over a privateeventsobject. This keeps the events map fully encapsulated (the old wrapper had a comment noting it wanted to hideemitter.e).Test plan