Replace javascript-natural-sort package with inline ESM implementation#3652
Open
andreialecu wants to merge 1 commit intojosdejong:developfrom
Open
Replace javascript-natural-sort package with inline ESM implementation#3652andreialecu wants to merge 1 commit intojosdejong:developfrom
andreialecu wants to merge 1 commit intojosdejong:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javascript-natural-sortdependency with an inline ESM modulePart of #3649
Details
The
javascript-natural-sortpackage hasn't been updated in 9+ years and only ships CommonJS. Rather than waiting for an upstream ESM build, this inlines the implementation as a clean ESM module.The implementation preserves the original algorithm while improving readability (descriptive variable names, extracted helper functions) and performance:
Key optimizations:
charCodeAtinstead of regex for leading-zero detection,.test()instead of.match()to avoid array allocations, hoisted inline regex literals to module-level constants, removed per-call closure allocation.Output is verified identical to the original package across all test data.
Test plan
compareNatural.test.jstests pass (20 tests)