This repository was archived by the owner on Sep 7, 2021. It is now read-only.
Build gainput as a shared library by using BUILD_SHARED option in CMake.#79
Open
jpvanoosten wants to merge 2 commits intojkuhlmann:masterfrom
Open
Build gainput as a shared library by using BUILD_SHARED option in CMake.#79jpvanoosten wants to merge 2 commits intojkuhlmann:masterfrom
jpvanoosten wants to merge 2 commits intojkuhlmann:masterfrom
Conversation
Additionally, the gainput shared library is copied to the sample's output directory on successful build.
Author
|
The 2nd commit also fixes up CMake configurations to provide the public include files and library dependencies required by targets that consume gainput. Also fixed a lot of compiler errors/warnings. Also removed failing test cases on Windows when using XInput ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #78, it is not possible to generate the project in CMake if either
GAIN_BUILD_SHAREDorGAIN_BUILD_STATICis disabled while generating the project. This pull request fixes this issue by relying on theBUILD_SHARED_LIBSbuilt-in option in CMake.The gainputstatic project should not be necessary if we rely on the fact that the user can switch between the shared and static variants by specifying the
BUILD_SHARED_LIBSoption accordingly.