[ISSUE-1177] Upgrade to latest handlebars.js (4.7.9) as 4.7.7 has security issues.#1178
Open
campeis wants to merge 1 commit intojknack:masterfrom
Open
[ISSUE-1177] Upgrade to latest handlebars.js (4.7.9) as 4.7.7 has security issues.#1178campeis wants to merge 1 commit intojknack:masterfrom
campeis wants to merge 1 commit intojknack:masterfrom
Conversation
campeis
commented
Apr 11, 2026
| Throwing.run(() -> engine.eval(Files.read(this.handlebarsJsFile, charset))); | ||
| Throwing.run(() -> { | ||
| //polyfill globalThis as it is used in handlebars 4.7.9 and is not supported by nashorn | ||
| engine.eval("var globalThis = this;"); |
Author
There was a problem hiding this comment.
add polyfill here instead of adding it to the handlebars.js file so that file could stay untouched.
campeis
force-pushed
the
update_handlebars_js_to_4_7_9
branch
from
ae7fb73 to
48a66cd
Compare
campeis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update handlebars.js to version 4.7.9 as 4.7.7 has security issues.
solves #1177