Skip to content

tests: run insta --force-update-snapshots#5888

Merged
ilyagr merged 1 commit intomainfrom
ig/insta-update-snapshots
Mar 6, 2025
Merged

tests: run insta --force-update-snapshots#5888
ilyagr merged 1 commit intomainfrom
ig/insta-update-snapshots

Conversation

@ilyagr
Copy link
Copy Markdown
Contributor

@ilyagr ilyagr commented Mar 6, 2025

This is a replacement for #5558. See the discussion over there for an explanation of the first commit.

(That commit is a bit cavalier, I may have missed some sport)

Thanks to @yuja 's mitsuhiko/insta#722, the second commit is now easy to generate.


I'm sending this out now with #5887 to front-load various "large-scale changes", so that there is one large hurdle for rebasing different PRs instead of many small ones.

@ilyagr ilyagr force-pushed the ig/insta-update-snapshots branch from 8b5190a to 45b113b Compare March 6, 2025 03:29
@ilyagr ilyagr marked this pull request as ready for review March 6, 2025 03:32
@ilyagr ilyagr changed the title tests: run insta --force-update-snapshots tests: run insta --force-update-snapshots, fixup formatter tests Mar 6, 2025
@ilyagr ilyagr force-pushed the ig/insta-update-snapshots branch from 45b113b to 49f19df Compare March 6, 2025 03:36
@ilyagr ilyagr marked this pull request as draft March 6, 2025 03:37
@ilyagr ilyagr force-pushed the ig/insta-update-snapshots branch from 49f19df to b9a0eec Compare March 6, 2025 03:39
@ilyagr ilyagr marked this pull request as ready for review March 6, 2025 03:39
@ilyagr ilyagr force-pushed the ig/insta-update-snapshots branch 2 times, most recently from 5a8697f to a8b1b23 Compare March 6, 2025 03:45
@martinvonz
Copy link
Copy Markdown
Member

FYI, @jakobhellermann (since you wrote #5558).

@ilyagr ilyagr force-pushed the ig/insta-update-snapshots branch from a8b1b23 to d663f96 Compare March 6, 2025 07:23
Comment thread cli/src/formatter.rs
This is a replacement for #5558.

Thanks to @yuja 's mitsuhiko/insta#722, this is
now easy to generate.
@ilyagr ilyagr force-pushed the ig/insta-update-snapshots branch from d663f96 to 695a243 Compare March 6, 2025 21:20
@ilyagr ilyagr changed the title tests: run insta --force-update-snapshots, fixup formatter tests tests: run insta --force-update-snapshots Mar 6, 2025
@ilyagr
Copy link
Copy Markdown
Contributor Author

ilyagr commented Mar 6, 2025

Thank you, Yuya!

@ilyagr ilyagr enabled auto-merge March 6, 2025 21:21
@ilyagr ilyagr added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit 5eae2d9 Mar 6, 2025
@ilyagr ilyagr deleted the ig/insta-update-snapshots branch March 6, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants