Allow marking a stream complete in propulsion#268
Closed
nordfjord wants to merge 1 commit intojet:masterfrom
Closed
Allow marking a stream complete in propulsion#268nordfjord wants to merge 1 commit intojet:masterfrom
nordfjord wants to merge 1 commit intojet:masterfrom
Conversation
This is useful for cases where you have a lot of small streams that get discarded, otherwise the StreamStates map grows uncontrollably for no value whatsoever. Adds a sentinel value of -2L to represent a completed stream, once this is returned the stream is removed from all state tracking. NOTE: This does mean that we lose some guarantees, the handler might be called again for the same stream due to at-least-once shenanigans.
Contributor
Author
|
Clsoing, probably not worth implementing |
Collaborator
|
Like #129 I don't mind feature idea sketches in PR form hanging around. That said, given it's not been proceeded with on the JS side, I can see the reasoning Though there's a lot to be said for having a short list of realistic things only (and keeping feature ideas like this in some form of longlist like jet/equinox#232) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for cases where you have a lot of small streams that get
discarded, otherwise the StreamStates map grows uncontrollably for no
value whatsoever.
Adds a sentinel value of -2L to represent a completed stream, once this
is returned the stream is removed from all state tracking.
NOTE: This does mean that we lose some guarantees, the handler might be
called again for the same stream due to at-least-once shenanigans.