fix(ci): align workflows with the default branch#1571
Closed
jaypatrick wants to merge 4 commits intomainfrom
Closed
fix(ci): align workflows with the default branch#1571jaypatrick wants to merge 4 commits intomainfrom
jaypatrick wants to merge 4 commits intomainfrom
Conversation
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to be compatible with repositories whose default branch may be main or master, and standardizes several workflow files’ YAML formatting.
Changes:
- Expand workflow triggers from
main-only tomaster/mainin multiple workflows. - Replace hard-coded
refs/heads/mainchecks withgithub.event.repository.default_branchcomparisons where supported. - Reformat/normalize YAML quoting and indentation across workflows.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/zta-lint.yml | Updates push branch filter to include master and normalizes quoting. |
| .github/workflows/sentry-worker.yml | Updates push branch filter to include master and normalizes quoting. |
| .github/workflows/sentry-frontend.yml | Updates push branch filter to include master and reindents/normalizes YAML. |
| .github/workflows/mdbook.yml | Updates push branch filter to include master and normalizes quoting. |
| .github/workflows/lighthouse.yml | Updates workflow_run branch filter to include master and normalizes YAML. |
| .github/workflows/frontend-version-bump.yml | Updates trigger branches to include master and reindents/normalizes YAML. |
| .github/workflows/db-migrate.yml | Updates triggers to include master, uses default-branch ref checks for apply jobs, and normalizes YAML. |
| .github/workflows/claude.yml | Updates push branch filter to include master and normalizes quoting. |
| .github/workflows/ci.yml | Updates triggers to include master, switches deploy/publish gating to default-branch refs, and normalizes YAML. |
| .github/workflows/bench.yml | Updates trigger branches to include master and normalizes quoting. |
| .github/workflows/api-shield-scan.yml | Updates triggers to include master and normalizes YAML. |
| .github/actions/deploy-worker/action.yml | Tweaks deploy action warning messaging related to container push permissions. |
Owner
Author
|
@copilot apply changes based on the comments in this thread |
…containers token Agent-Logs-Url: https://github.com/jaypatrick/adblock-compiler/sessions/0601fd03-580e-48e9-8356-aac245e8c8c5 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Contributor
Applied all four changes from the review thread in commit
|
Owner
Author
|
@copilot apply changes based on the comments in this thread |
…branch equivalents Agent-Logs-Url: https://github.com/jaypatrick/adblock-compiler/sessions/483724fe-4263-403a-8765-5ab4673344e7 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Contributor
Applied all five changes from the review thread in commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
Testing
Zero Trust Architecture Checklist
Worker / Backend
*) on write/authenticated endpoints[vars]).prepare().bind()(no string interpolation)Frontend / Angular
CanActivateFnauth guardslocalStorage)API Shield / Vulnerability Scanner
operationIdinopenapi.yaml/{id}path parameters) include asecurity:annotationWHERE user_id = ?) — not just by ID404(not403) to avoid leaking resource existencecloudflare-schema.yamlregenerated ifopenapi.yamlchanged (deno task schema:cloudflare)If this PR does not touch
worker/orfrontend/, the ZTA checklist is not required.If this PR does not touch
openapi.yamlor resource handlers, the API Shield checklist is not required.