Replace GZIP compression with Brotli#22
Merged
jakobhellermann merged 1 commit intojakobhellermann:mainfrom Aug 6, 2022
Merged
Conversation
daxpedda
commented
Aug 6, 2022
|
|
||
| let serve_wasm = || async move { | ||
| (TypedHeader(ContentEncoding::gzip()), WithContentType("application/wasm", compressed_wasm)) | ||
| ([("content-encoding", "br")], WithContentType("application/wasm", compressed_wasm)) |
Contributor
Author
There was a problem hiding this comment.
This is a bit unfortunate, see hyperium/headers#116.
Owner
|
I noticed that with a large wasm file compression was taking a lot of time (~50s) so I looked at the Looks like brotli definitely is the better option, but a compression level of 5 may be the best trade off. |
Contributor
Author
|
50 sec is incredibly long ... LGTM. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #15. This replaces the GZIP compression with Brotli. This shouldn't be a problem as all browsers support Brotli nowadays, see https://caniuse.com/brotli.
My WASM files are now consistently about a third smaller.