An OC update to streamline a few functions and improve functionality#3
Open
attosecond wants to merge 39 commits intointerfect:masterfrom
Open
An OC update to streamline a few functions and improve functionality#3attosecond wants to merge 39 commits intointerfect:masterfrom
attosecond wants to merge 39 commits intointerfect:masterfrom
Conversation
Changed namespace KerbalTestOne to OrbitalConstruction
Changed namespace from KerbalTestOne to OrbitalConstruction
Changed namespace from KerbalTestOne to OrbitalConstruction
Namespace and assembly name updates require a new csproj file.
Updated the namespace (of course) and made some code changes. Instead of using RequestResource() to check part availability, I just ask each PartResource for its amount property. It allows me to query individual warehouses, instead of the rootPart. This way a conglomeration of vessels joined by docking ports can all provide RocketParts when building, presuming at least one vessel has a SpaceDock. Previously, the rootPart would only provide access to warehouse inventory if that warehouse was an original component of the rootPart's vessel.
simpler search for spacedocks, and much simpler mass calculation
Found a code snippet from the RemoteTech mods that shows how to scan for parts without loading vessels. The dock scan is WAY faster, and no messy issues with KAS-enabled vessels loading and then unloading in quick succession.
A poorly placed Vessel.Unload() statement was to blame. All better now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor streamlining changes (easier mass calc, simplified spacedock identification). Updated the namespace and assembly output to OrbitalConstruction. KerbalTestOne just didn't do it for me. Also updated the RocketParts quantity check and allocation functions to work across multiple docked vessels.