feat(ui-drilldown,ui-options,ui): rework Drilldown#2469
feat(ui-drilldown,ui-options,ui): rework Drilldown#2469
Conversation
| // points to another component's theme ID to display its theme variables | ||
| // (e.g. Drilldown.Group uses Options theme, so themeId: "Options") | ||
| themeId?: string |
There was a problem hiding this comment.
Drilldown displays the token of Options in some of its subcomponents, so I implemented this functionality without the theme.ts files like in v11_6
|
matyasf
left a comment
There was a problem hiding this comment.
Can you please write about the token changes in the upgrade guide? While the Drilldown tokens itself havent changed, its using other components which did, so just a sentence like "Drilldown.Option is an Options.Item, Drilldown.Separator an Options.Separator under the hood, so token the token changes are the same"
Otherwise it looks good, nice work!
9954eb6 to
2d6f8af
Compare
I added this. |
INSTUI-4792
ISSUE:
TEST PLAN: