Skip to content

fix: nodes field returning nil on nested collections #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolerenee merged 1 commit into from
Aug 6, 2025
Merged

fix: nodes field returning nil on nested collections #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion entx/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func WithFederation() ExtensionOption {
// WithConnectionNodes adds the templates for adding nodes to relay connections
func WithConnectionNodes() ExtensionOption {
return func(ex *Extension) error {
ex.templates = append(ex.templates, PaginationTemplate)
ex.templates = append(ex.templates, PaginationTemplate, CollectionTemplate)
ex.gqlSchemaHooks = append(ex.gqlSchemaHooks, addNodesToConnections)

return nil
Expand Down
3 changes: 3 additions & 0 deletions entx/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ var (
// PaginationTemplate adds support for adding the nodes field to relay connections
PaginationTemplate = parseT("template/pagination.tmpl")

// CollectionTemplate adds support for adding the nodes field to relay connections
CollectionTemplate = parseT("template/collection.tmpl")

// TemplateFuncs contains the extra template functions used by entx.
TemplateFuncs = template.FuncMap{
"contains": strings.Contains,
Expand Down
Loading
Loading