Allow structs without public fields to implement Setter#83
Open
urso wants to merge 1 commit intoilyakaznacheev:masterfrom
Open
Allow structs without public fields to implement Setter#83urso wants to merge 1 commit intoilyakaznacheev:masterfrom
urso wants to merge 1 commit intoilyakaznacheev:masterfrom
Conversation
If a struct does not provide a public field that might be set by cleanenv, then the struct was ignored. This did make it impossible to implement a custom struct with SetValue. The change checks if a field implements SetValue. If SetValue is implemented we stop recursing into the type to looks for other fields that might be populated via cleanenv.
|
I also needed this functionality. My goals was to support validation of custom types during config loading. Before finding this PR, my forked version implements the solution the same way. @ilyakaznacheev first off, thank you for creating this library! It's been very helpful. Secondly, are there any blockers I could help with to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a struct does not provide a public field that might be set by cleanenv, then the struct was ignored. This did make it impossible to implement a custom struct with SetValue.
The change checks if a field implements SetValue. If SetValue is implemented we stop recursing into the type to looks for other fields that might be populated via cleanenv.
The new example test used to fail because SetValue was not called.