redfish_aggregator: Mutual aggregation support#1391
Open
abhilashraju wants to merge 1 commit intoibm-openbmc:1120from
Open
redfish_aggregator: Mutual aggregation support#1391abhilashraju wants to merge 1 commit intoibm-openbmc:1120from
abhilashraju wants to merge 1 commit intoibm-openbmc:1120from
Conversation
At present bmcweb does not support mutual aggregation. Any bmc should be able to aggregate resources from its peers. Bmcweb will be compiled with aggregation enabled for both satellite and master BMCs. Bmcweb should be able to distinguish between the requests originated from its peer BMC and external redfish clients. Otherwise aggregation will end up in indefinite mutual aggregation loop. This commit will add extra header to identify the aggregation request from peers. This implementation assumes that any type of transitive aggregation is not present( A aggregates B aggregates C etc). If we have such requirement then we can enhance header property to hold all parent bmc information to filter and avoid any aggregation loop. Change-Id: Ie11c39cf8bc9b014aad700bf9199cb6ceb4c56fb Signed-off-by: Abhilash Raju <abhilash.kollam@gmail.com>
abhilashraju
force-pushed
the
fixing_loop_in_mutual_aggregation
branch
from
13b6ce8 to
e571803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present bmcweb does not support mutual aggregation. Any bmc should be able to aggregate resources from its peers.
Bmcweb will be compiled with aggregation enabled for both satellite and master BMCs. Bmcweb should be able to distinguish between the requests originated from its peer BMC and external redfish clients. Otherwise aggregation will end up in indefinite mutual aggregation loop.
This commit will add extra header to identify the aggregation request from peers.
This implementation assumes that any type of transitive aggregation is not present( A aggregates B aggregates C etc).
If we have such requirement then we can enhance header property to hold all parent bmc information to filter and avoid any aggregation loop.
Upstream commit https://gerrit.openbmc.org/c/openbmc/bmcweb/+/71685
Change-Id: Ie11c39cf8bc9b014aad700bf9199cb6ceb4c56fb