Open
Conversation
truekonrads
commented
May 19, 2018
truekonrads
commented
- This PR fixes a NULL pointer deref and crash issue when domain is empty (no --dns or domain).
- It also changes -d to --debug (and -q to --quiet) as try as I might the getopt_long_only routine that is used to parse it would fail on Sol10.
- Squelch of warnings in uECC.c file to allow a debug build compile.
…ound a bug on Solaris 10 whereby these options in their short version would be treated as unknown options. Small price to pay...
- moved -g flag to debugflugs - added -ggdb - squelched char-subscript error in uECC.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.