Skip to content

ASP-2043: Add typed gRPC built-in retry support to GrpcChannelConfig #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-steinfeld merged 3 commits into from
Apr 24, 2026
Merged

ASP-2043: Add typed gRPC built-in retry support to GrpcChannelConfig #93

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fe9c35
ASP-2043: Add serviceConfig support to GrpcChannelConfig for gRPC bui…
kunalvaswani123 Apr 24, 2026
299a909
ASP-2043: Type serviceConfig in GrpcChannelConfig using GrpcServiceCo…
kunalvaswani123 Apr 24, 2026
9aa00a1
ASP-2043: Address PR review comments - typed Duration, enableRetry op…
kunalvaswani123 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions grpc-client-utils/src/main/java/org/hypertrace/core/grpcutils/client/GrpcChannelConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import io.grpc.ClientInterceptor;
import java.util.List;
import java.util.Map;
import lombok.Builder;
import lombok.Singular;
import lombok.Value;
Expand All @@ -12,4 +13,6 @@ public class GrpcChannelConfig {
Integer maxInboundMessageSize;

@Singular List<ClientInterceptor> clientInterceptors;

Map<String, Object> serviceConfig;
}
3 changes: 3 additions & 0 deletions ...-client-utils/src/main/java/org/hypertrace/core/grpcutils/client/GrpcChannelRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ protected ManagedChannel configureAndBuildChannel(
if (config.getMaxInboundMessageSize() != null) {
builder.maxInboundMessageSize(config.getMaxInboundMessageSize());
}
if (config.getServiceConfig() != null) {
builder.defaultServiceConfig(config.getServiceConfig()).enableRetry();
Comment thread
aaron-steinfeld marked this conversation as resolved.
Outdated
}
this.registryConfig.getDefaultInterceptors().forEach(builder::intercept);
return builder.intercept(config.getClientInterceptors()).build();
}
Expand Down
16 changes: 16 additions & 0 deletions ...ent-utils/src/test/java/org/hypertrace/core/grpcutils/client/GrpcChannelRegistryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import io.grpc.ManagedChannel;
import io.grpc.ManagedChannelBuilder;
import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -145,6 +146,21 @@ void copyConstructorReusesExistingChannels() {
assertSame(firstChannel, new GrpcChannelRegistry(firstRegistry).forSecureAddress("foo", 1000));
}

@Test
void createsDistinctChannelsForDifferentServiceConfigs() {
Map<String, Object> serviceConfig = Map.of("methodConfig", List.of());
Channel channelWithServiceConfig =
this.channelRegistry.forSecureAddress(
"foo", 1000, GrpcChannelConfig.builder().serviceConfig(serviceConfig).build());

assertNotNull(channelWithServiceConfig);
assertNotSame(channelWithServiceConfig, this.channelRegistry.forSecureAddress("foo", 1000));
assertSame(
Comment thread
aaron-steinfeld marked this conversation as resolved.
Outdated
channelWithServiceConfig,
this.channelRegistry.forSecureAddress(
"foo", 1000, GrpcChannelConfig.builder().serviceConfig(serviceConfig).build()));
}

@Test
void registersRegistryInterceptors() {
try (MockedStatic<ManagedChannelBuilder> mockedBuilderStatic =
Expand Down
Loading