Merged
Conversation
meanmail
approved these changes
Mar 19, 2026
Contributor
meanmail
left a comment
meanmail
left a comment
There was a problem hiding this comment.
The fix correctly inverts the condition from taskFile == null to taskFile != null.
Previously, refactoring was forbidden when a file was not part of a course (taskFile is null), which is backwards. Now it's forbidden only when the file is a course task file — consistent with the PsiDirectory branch on the next line (dir.getStudyItem(project) != null).
Clean one-line fix, LGTM.
meanmail
reviewed
Mar 19, 2026
intellij-plugin/hs-core/src/org/hyperskill/academy/learning/handlers/handlersUtils.kt
Show resolved
Hide resolved
meanmail
reviewed
Mar 22, 2026
intellij-plugin/hs-core/testSrc/org/hyperskill/academy/learning/handlers/HandlersUtilsTest.kt
Show resolved
Hide resolved
meanmail
approved these changes
Mar 24, 2026
Contributor
meanmail
left a comment
meanmail
left a comment
There was a problem hiding this comment.
LGTM. Fix is correct, tests cover the key scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23
Fixed. Tested in own IDEA 252 (built and locally installed)