fix(fabric): correct shared job template image vars#2681
Open
malsomesh9 wants to merge 1 commit intohyperledger-bevel:mainfrom
Open
fix(fabric): correct shared job template image vars#2681malsomesh9 wants to merge 1 commit intohyperledger-bevel:mainfrom
malsomesh9 wants to merge 1 commit intohyperledger-bevel:mainfrom
Conversation
Signed-off-by: malsomesh9 <malsomesh9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Fabric minikube deployment regressions from issue #2659 that are still reproducible in the shared job component templates.
Changes
fabric_tools_imageandbevel_alpine_versionfromcharts.*, which matches how these values are defined in the shared role varsupdate_repo_cache: truefrom the shared Helm install task so local/chart-path installs do not fail when no Helm repo has been addedNotes
create-join-channel.yamlplaybook paths referenced in the report still exist in the current tree, so this PR keeps scope to the two concrete repo-level failures I could confirm directlyFixes #2659