Skip to content

Fix: propagate interpolate_pos_encoding through PixioEmbeddings and PixioModel#44723

Closed
aashirpersonal wants to merge 1 commit intohuggingface:mainfrom
aashirpersonal:fix/pixio-interpolate-pos-encoding
Closed

Fix: propagate interpolate_pos_encoding through PixioEmbeddings and PixioModel#44723
aashirpersonal wants to merge 1 commit intohuggingface:mainfrom
aashirpersonal:fix/pixio-interpolate-pos-encoding

Conversation

@aashirpersonal
Copy link

@aashirpersonal aashirpersonal commented Mar 15, 2026

Summary

This PR fixes #44716 by exposing and forwarding interpolate_pos_encoding through the Pixio embedding/model call chain so the option is actually usable from PixioModel.forward().

Changes

  • Added interpolate_pos_encoding: bool = False to PixioEmbeddings.forward() and forwarded it to self.patch_embeddings(...).
  • Added interpolate_pos_encoding: bool = False to PixioModel.forward() and forwarded it to self.embeddings(...).
  • Kept behavior and defaults aligned with similar vision models (e.g. SigLIP patterns) by defaulting to False.

Why

PixioPatchEmbeddings.forward() already accepted interpolate_pos_encoding, but higher-level modules did not pass it through, making the parameter effectively inaccessible for end users.

Issue: #44716

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: pixio

@Rocketknight1
Copy link
Member

No drive-by code agent PRs, please! We block people who do this repeatedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PixioPatchEmbeddings.forward supports interpolate_pos_encoding but it is not propagated through PixioEmbeddings/PixioModel

2 participants