Fix: propagate interpolate_pos_encoding through PixioEmbeddings and PixioModel#44723
Closed
aashirpersonal wants to merge 1 commit intohuggingface:mainfrom
Closed
Fix: propagate interpolate_pos_encoding through PixioEmbeddings and PixioModel#44723aashirpersonal wants to merge 1 commit intohuggingface:mainfrom
aashirpersonal wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: pixio |
Member
|
No drive-by code agent PRs, please! We block people who do this repeatedly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #44716 by exposing and forwarding
interpolate_pos_encodingthrough the Pixio embedding/model call chain so the option is actually usable fromPixioModel.forward().Changes
interpolate_pos_encoding: bool = FalsetoPixioEmbeddings.forward()and forwarded it toself.patch_embeddings(...).interpolate_pos_encoding: bool = FalsetoPixioModel.forward()and forwarded it toself.embeddings(...).False.Why
PixioPatchEmbeddings.forward()already acceptedinterpolate_pos_encoding, but higher-level modules did not pass it through, making the parameter effectively inaccessible for end users.Issue: #44716