fix: Correct rms_norm_eps type hint from int to float in MistralConfig#44702
Open
LincolnBurrows2017 wants to merge 4 commits intohuggingface:mainfrom
Open
fix: Correct rms_norm_eps type hint from int to float in MistralConfig#44702LincolnBurrows2017 wants to merge 4 commits intohuggingface:mainfrom
LincolnBurrows2017 wants to merge 4 commits intohuggingface:mainfrom
Conversation
added 4 commits
March 13, 2026 20:44
The rms_norm_eps parameter was incorrectly typed as int | None but defaults to 1e-6 which is a float. This parameter is passed to MistralRMSNorm which expects eps: float. This is a type hint bug that affects 59+ model configurations in the codebase.
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: doge, mistral, qwen2_vl, qwen3_5, qwen3_vl |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44702&sha=550a95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR fix?
The
rms_norm_epsparameter inMistralConfigwas incorrectly typed asint | Nonebut defaults to1e-6which is a float. This parameter is passed toMistralRMSNormwhich expectseps: float.Bug Details
Example
This is a simple one-line fix that corrects the type annotation.