Skip to content

Update auditwheel to 6.4.2#880

Merged
agners merged 1 commit intohome-assistant:masterfrom
cdce8p:update-auditwheel-6.4.2
Jul 31, 2025
Merged

Update auditwheel to 6.4.2#880
agners merged 1 commit intohome-assistant:masterfrom
cdce8p:update-auditwheel-6.4.2

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Jul 30, 2025

Comment on lines -19 to +28
+ "armv6l": "libc.musl-armvhf.so.1",
"armv7l": "libc.musl-armv7.so.1",
"riscv64": "libc.musl-riscv64.so.1",
}
@@ -295,6 +295,7 @@ def _fixup_musl_libc_soname(
Architecture.aarch64: "libc.musl-aarch64.so.1",
Architecture.s390x: "libc.musl-s390x.so.1",
Architecture.ppc64le: "libc.musl-ppc64le.so.1",
+ Architecture.armv6l: "libc.musl-armhf.so.1",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the libc filename is actually libc.musl-armhf.so.1 (without the v). See https://pkgs.alpinelinux.org/contents?name=musl&repo=main&branch=v3.22&arch=armhf

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh I see, nice find! Shouldn't this have caused issues for armv6l builds? 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's just that libc won't be whitelisted anymore and thus always copied into the wheel. I.e. with this fix the new wheels for armv6 will probably be noticeable smaller.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, nice!

Copy link
Copy Markdown
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment on lines -19 to +28
+ "armv6l": "libc.musl-armvhf.so.1",
"armv7l": "libc.musl-armv7.so.1",
"riscv64": "libc.musl-riscv64.so.1",
}
@@ -295,6 +295,7 @@ def _fixup_musl_libc_soname(
Architecture.aarch64: "libc.musl-aarch64.so.1",
Architecture.s390x: "libc.musl-s390x.so.1",
Architecture.ppc64le: "libc.musl-ppc64le.so.1",
+ Architecture.armv6l: "libc.musl-armhf.so.1",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh I see, nice find! Shouldn't this have caused issues for armv6l builds? 🤔

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Jul 31, 2025

@agners Would you mind doing a new release after this (and maybe #882) are merged? A while ago we bumped the images to alpine 3.22 (#874). A new release would allow us to loosen the pin for rpds-py over in core which will be required for Python 3.14 support. home-assistant/core#145074

@agners agners merged commit bf4ddde into home-assistant:master Jul 31, 2025
8 checks passed
@cdce8p cdce8p deleted the update-auditwheel-6.4.2 branch July 31, 2025 11:35
@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Jul 31, 2025

Just saw the release. Thanks!

@agners Could you restart the failing publish job on master? Not sure if we'd encounter any test issues as the CI run here uses these instead of the releases. https://github.com/home-assistant/wheels/actions/runs/16647855358/job/47112734991

cdce8p added a commit to cdce8p/wheels that referenced this pull request Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants