fix(bash): highlight command-line options#4369
Open
KJyang-0114 wants to merge 2 commits intohighlightjs:mainfrom
Open
fix(bash): highlight command-line options#4369KJyang-0114 wants to merge 2 commits intohighlightjs:mainfrom
KJyang-0114 wants to merge 2 commits intohighlightjs:mainfrom
Conversation
When highlightElement is called on already-highlighted code (e.g., consecutive hljs.highlightAll() calls), the existing <span class="hljs-*"> tags from the previous highlighting are incorrectly flagged as "unescaped HTML" - a false positive security warning. This fix checks for the data-highlighted attribute early and silently skips re-highlighting, matching the proposed solution in issue highlightjs#3761.
Add OPTIONS pattern to highlight command-line options like --project, --deployment-package, -f, etc. This fixes inconsistent highlighting where some options were highlighted as built_in while others had no highlighting at all. Fixes: highlightjs#4288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add OPTIONS pattern to highlight command-line options like --project, --deployment-package, -f, etc. This fixes inconsistent highlighting where some options were highlighted as built_in while others had no highlighting at all.
Fixes
Fixes #4288
Testing
The fix adds proper highlighting for:
Screenshots
Before: Some options had no highlighting
After: All options are highlighted with the 'attribute' class