Fix for Issue 122 - Resolve Sinatra dependency to '2.0.0.beta2' in Gemspec#122
Open
mrjonesbot wants to merge 5 commits intohighfidelity:masterfrom
mrjonesbot:update-dependancies
Open
Fix for Issue 122 - Resolve Sinatra dependency to '2.0.0.beta2' in Gemspec#122mrjonesbot wants to merge 5 commits intohighfidelity:masterfrom mrjonesbot:update-dependancies
mrjonesbot wants to merge 5 commits intohighfidelity:masterfrom
mrjonesbot:update-dependancies
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue referenced here: #121
Prior to 2.0.0.beta2, Sinatra supported an incorrect Rack requirement for the showexceptions file:
sinatra/sinatra#1055
When attempting to load fake_braintree into the test environment, I'd receive this error highlighted in the issue above:
local/bundle/gems/sinatra-1.0/lib/sinatra/showexceptions.rb:1:in 'require': cannot load such file -- rack/showexceptions (LoadError)By updating Sinatra in the gemspec, the ability to load the gem via Rack is restored.
This PR does not address the 3 failing spec tests.