refactor: remove unused dependencies and replace lodash with native JavaScript#272
Merged
refactor: remove unused dependencies and replace lodash with native JavaScript#272
Conversation
…avaScript Remove unused dependencies (lodash.sortby, chai-as-promised, ts-node) and replace with native implementations to reduce bundle size and simplify the codebase. - Replace lodash.sortby with native Array.sort() in kafka:info command - Refactor chai-as-promised tests to use native async/await patterns - Remove ts-node configuration (using tsx instead) - Fix high severity security vulnerability in flatted package
michaelmalave
approved these changes
Mar 13, 2026
Contributor
michaelmalave
left a comment
michaelmalave
left a comment
There was a problem hiding this comment.
Nice removal, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes unused dependencies and replaces lodash utilities with native JavaScript implementations to reduce bundle size, simplify the codebase, and fix security vulnerabilities.
Changes:
lodash.sortbyand@types/lodash.sortby- replaced with nativeArray.sort()inkafka:infocommandchai-as-promised- refactored tests intest/lib/clusters-test.tsto use native async/await patterns with try/catchts-nodeconfiguration fromtsconfig.json(project usestsxinstead viaNODE_OPTIONS)flattedpackage vianpm audit fixRemaining vulnerabilities:
diffpackage (mocha dependency) - acceptable as they only affect test environment and require malicious test inputType of Change
Patch Updates (patch semver update)
Testing
Notes:
All existing tests pass without modification to test behavior.
Steps:
Related Issues
Part of ongoing effort to modernize the codebase and reduce unnecessary dependencies.