Add more misspellings to the .python-version filename check#2051
Merged
Add more misspellings to the .python-version filename check#2051
.python-version filename check#2051Conversation
Based on misspellings seen in Honeycomb, that affected more than one app. Having this fixed list of misspellings isn't ideal (given there will be a long tail of misspellings not on it), however, short term it allows us to offer a very specific error message so the majority of apps are fixed by their owners, whilst still maintaining a low false positive rate (vs a looser regex). Longer term we'll likely be making the `.python-version` file mandatory, at which point the error message for that can list out the files in the app source root (the same way we do for detection errors), which will help with the long tail cases. (We can also do things like replace unicode or stray whitespace in the file listing, to make those confusing for the user cases easier to spot too.) GUS-W-21320154.
dzuelke
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on misspellings seen in Honeycomb, that affected more than one app.
Having this fixed list of misspellings isn't ideal (given there will be a long tail of misspellings not on it), however, short term it allows us to offer a very specific error message so the majority of apps are fixed by their owners, whilst still maintaining a low false positive rate (vs a looser regex).
Longer term we'll likely be making the
.python-versionfile mandatory, at which point the error message for that can list out the files in the app source root (the same way we do for detection errors), which will help with the long tail cases. (We can also do things like replace unicode or stray whitespace in the file listing, to make those particularly-confusing-for-the-user cases easier to spot too.) See also here.GUS-W-21320154.