Update test fixture after change in S3 bucket permissions#2048
Merged
Conversation
S3 directory listing permissions were removed from the buildpack's S3 bucket, which means non-existent files now return 403 rather than 404. The implementation for error handling works with both: https://github.com/heroku/heroku-buildpack-python/blob/855d7e66d99357f814f74a1e0920f6c0f377f64f/lib/python.sh#L74-L75 The test assertion has been loosened to make it less sensitive to the exact curl output. GUS-W-21443369.
runesoerensen
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 directory listing permissions were removed from the buildpack's S3 bucket, which means non-existent files now return 403 rather than 404.
The implementation for error handling already works with both:
heroku-buildpack-python/lib/python.sh
Lines 74 to 76 in 855d7e6
However, the test assertion needs to be loosened to resolve this CI failure:
https://github.com/heroku/heroku-buildpack-python/actions/runs/22640940619/job/65680836050#step:5:497
GUS-W-21443369.