Skip to content

feat(gdb): Make gdb code mostly platform/architecture-independent#1315

Open
fogti wants to merge 14 commits intohermit-os:mainfrom
fogti:gdb-stub-arch-indep
Open

feat(gdb): Make gdb code mostly platform/architecture-independent#1315
fogti wants to merge 14 commits intohermit-os:mainfrom
fogti:gdb-stub-arch-indep

Conversation

@fogti
Copy link
Copy Markdown
Contributor

@fogti fogti commented Mar 18, 2026

This is a squash of many intermediate, quite experimental steps, which made rebasing essentially impossible.

Supersedes fogti#1

@fogti fogti added rust Pull requests that update Rust code feature/debugger Features involving the debugging facilities of uhyve, i.e. the GDBstub implementation. labels Mar 18, 2026
@fogti fogti force-pushed the gdb-stub-arch-indep branch from 74beebd to 41ba7d8 Compare March 18, 2026 12:13
@n0toose n0toose force-pushed the gdb-stub-arch-indep branch from f37bf70 to a2f888d Compare March 18, 2026 12:38
@fogti fogti force-pushed the gdb-stub-arch-indep branch from 790dcba to f273035 Compare March 18, 2026 12:47
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 88.34499% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.79%. Comparing base (5e88f40) to head (09a31e2).

Files with missing lines Patch % Lines
src/gdb/mod.rs 85.25% 32 Missing ⚠️
src/gdb/resume.rs 82.71% 14 Missing ⚠️
src/gdb/base.rs 96.51% 3 Missing ⚠️
src/linux/mod.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
+ Coverage   76.39%   76.79%   +0.39%     
==========================================
  Files          29       29              
  Lines        4266     4292      +26     
==========================================
+ Hits         3259     3296      +37     
+ Misses       1007      996      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fogti fogti force-pushed the gdb-stub-arch-indep branch 6 times, most recently from 3305c62 to 8c1c72c Compare March 18, 2026 14:32
@fogti fogti changed the title feat(gdb): Make gdb code less Linux-dependent feat(gdb): Make gdb code mostly platform/architecture-independent Mar 18, 2026
@fogti fogti marked this pull request as ready for review March 18, 2026 14:39
@fogti fogti requested a review from jounathaen March 18, 2026 14:39
@fogti
Copy link
Copy Markdown
Contributor Author

fogti commented Mar 18, 2026

Should something be done about the integration test tests/gdb.rs still being marked as Linux-only?

@fogti fogti force-pushed the gdb-stub-arch-indep branch from 8c1c72c to aa90cfc Compare March 19, 2026 10:13
@fogti
Copy link
Copy Markdown
Contributor Author

fogti commented Mar 19, 2026

The main reason I didn't squash this yet is because we might need to undo parts of this later (e.g. the part that messes with the gdb_port presence on MacOS).

@fogti fogti force-pushed the gdb-stub-arch-indep branch from aa90cfc to 03eb026 Compare March 25, 2026 15:19
fogti and others added 11 commits April 7, 2026 14:45
This is a squash of many intermediate, quite experimental steps,
which made rebasing essentially impossible.

Co-authored-by: Panagiotis "Ivory" Vasilopoulos <git@n0toose.net>
- Use macOS-specific KickSignal
- Fix some XhyveCpu implementations
- Stub out/exclude unused gdb portions
- Use explicit allow(dead_code) to show warnings/what's missing
- Add placeholder AllBreakpoints for macOS
- Add placeholder DebugExitInfo (may need to be replaced)
@fogti fogti force-pushed the gdb-stub-arch-indep branch from 03eb026 to 09a31e2 Compare April 7, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/debugger Features involving the debugging facilities of uhyve, i.e. the GDBstub implementation. rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants