fix: flake.nix#15588
Closed
matoous wants to merge 1 commit intohelix-editor:masterfrom
Closed
Conversation
Use rust-toolchain.toml to make nix use the same pinned toolchain as the rest of the repository.
Member
the-mikedavis
left a comment
the-mikedavis
left a comment
There was a problem hiding this comment.
For the checks phase and the shell we want to use the MSRV but for building the package we should use the latest stable Rust like we do for releases. I believe the flake dependencies haven't been updated in a while and we need to nix flake update and commit the flake.lock changes
Member
|
I pushed up f968687 to update the dependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use rust-toolchain.toml to make nix use the same pinned toolchain as the rest of the repository.
Disclaimer: I have limited experience with Nix, used it for a while but don't do any more, please review thoroughly.
Fixes: #15537