Change Terminology for Light Hotspots#1309
Open
Ryan-Goldstein wants to merge 1 commit intohelium:mainfrom
Open
Change Terminology for Light Hotspots#1309Ryan-Goldstein wants to merge 1 commit intohelium:mainfrom
Ryan-Goldstein wants to merge 1 commit intohelium:mainfrom
Conversation
Mirroring changes made to the StatusWidget in Explorer for Light Hotspots, changing "Online" to "Active" and "Needs Attention" to "Inactive". Justification for the change from "Needs Attention" is that, at least with the current PoC issues, that has been resulting in unnecessary or counterproductive actions, like perpetually power cycling, switching from Ethernet to Wi-Fi, etc. "Inactive" provides the necessary information without implying that action needs to be taken, and it matches what's shown on Explorer. Note: If this change is merged, the other language files should probably be similarly changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirroring changes made to the StatusWidget in Explorer for Light Hotspots, changing "Online" to "Active" and "Needs Attention" to "Inactive".
Justification for the change from "Needs Attention" is that, at least with the current PoC issues, that has been resulting in unnecessary or counterproductive actions, like perpetually power cycling, switching from Ethernet to Wi-Fi, etc. "Inactive" provides the necessary information without implying that action needs to be taken, and it matches what's shown on Explorer.
Note: If this change is merged, the other language files should probably be similarly changed.