Remove -Wno-incomplete-uni-patterns#11734
Open
philderbeast wants to merge 1 commit intohaskell:masterfrom
Open
Remove -Wno-incomplete-uni-patterns#11734philderbeast wants to merge 1 commit intohaskell:masterfrom
philderbeast wants to merge 1 commit intohaskell:masterfrom
Conversation
geekosaur
approved these changes
Apr 11, 2026
ulysses4ever
approved these changes
Apr 11, 2026
Collaborator
ulysses4ever
left a comment
There was a problem hiding this comment.
Thanks!
Any chance you could squash the commit history?
- -XViewPatterns avoids -Wincomplete-uni-patterns - Use the safer Map.!? operator - Add MonadFail Match, drop ~KnownPackage match - Drop --Wno-incomplete-uni-patterns in Errors - Remove -Wno-incomplete-uni-patterns in Storage - Remove unused -Wno-incomplete-uni-patterns
fbe9407 to
e4b7fbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all uses of
-Wno-incomplete-uni-patternsexcept the one remaining incabal-install-solverwith lazy pattern matching that seems a bit hairy, as shown below:cabal/cabal-install-solver/src/Distribution/Solver/Modular/Linking.hs
Lines 4 to 5 in 8974189
cabal/cabal-install-solver/src/Distribution/Solver/Modular/Linking.hs
Lines 249 to 274 in 8974189