Remove quantified constraints in FieldGrammar

[leana8959]

Previously field grammar was written with quantified constraints, this PR refactors them to concrete types (there's actually not a lot of them!). This would help the exact print project and in general make it easier to scrutinize which term is requiring which constraint.

EDIT: at the request of Jappie, here's an error caused by an application of type family on a quantified constraint when implementing exact print. Removing the quantification helps the compiler resolve this constraint.

error message

src/Distribution/PackageDescription/FieldGrammar.hs:718:6: error: [GHC-73138]
    • Illegal type synonym family application ‘Annotate
                                                 mod (RelativePath from to)’ in instance:
        Newtype
          [Annotate mod (RelativePath from to)]
          (ListWith mod FSep (RelativePathNT from to) (RelativePath from to))
    • In the quantified constraint ‘forall from (to :: FileOrDir).
                                    Newtype
                                      [Annotate mod (RelativePath from to)]
                                      (ListWith
                                         mod FSep (RelativePathNT from to) (RelativePath from to))’
      In the type signature:
        buildInfoFieldGrammar' :: forall mod
                                         c
                                         g. (FieldGrammarWith mod c g,
                                             Applicative (g mod (BuildInfoWith mod)),
                                             L.HasBuildInfoWith mod (BuildInfoWith mod),
                                             Newtype [Annotate mod LegacyExeDependency] (ListWith mod CommaFSep (Identity LegacyExeDependency) LegacyExeDependency),
                                             c (ListWith mod CommaFSep (Identity LegacyExeDependency) LegacyExeDependency),
                                             Newtype [Annotate mod ExeDependency] (ListWith mod CommaFSep (Identity ExeDependency) ExeDependency),
                                             c (ListWith mod CommaFSep (Identity ExeDependency) ExeDependency),
                                             Newtype [Annotate mod String] (ListWith mod NoCommaFSep Token' String),
                                             c (ListWith mod NoCommaFSep Token' String),
                                             Newtype [Annotate mod PkgconfigDependency] (ListWith mod CommaFSep (Identity PkgconfigDependency) PkgconfigDependency),
                                             c (ListWith mod CommaFSep (Identity PkgconfigDependency) PkgconfigDependency),
                                             forall from to.
                                             Newtype [Annotate mod (RelativePath from to)] (ListWith mod FSep (RelativePathNT from to) (RelativePath from to)),
                                             c (ListWith mod FSep (RelativePathNT Framework File) (RelativePath Framework File)),
                                             Newtype [Annotate mod (DependencyWith mod)] (ListWith mod CommaVCat (Identity (DependencyWith mod)) (DependencyWith mod)),
                                             c (ListWith mod CommaVCat (Identity (DependencyWith mod)) (DependencyWith mod))) =>
                                            g mod (BuildInfoWith mod) (BuildInfoWith mod)
    |
718 |   :: forall mod c g
    |      ^^^^^^^^^^^^^^...

This change doesn't change behaviour or interface.

• Patches conform to the coding conventions.
• Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

[ffaf1]

Seems reasonable!

[leana8959]

Drafting because I forgot to remove the language extension "QuantifiedConstraints".

[sheaf]

Yes, this looks fine (modulo actually removing the LANGUAGE pragma of course). I felt slightly bad for adding the quantified constraints in the first place; I agree it's not so bad to spell them out. Thanks!