chore(cabal-install-solver): remove traceTree#11651
Open
andreabedini wants to merge 1 commit intohaskell:masterfrom
Open
chore(cabal-install-solver): remove traceTree#11651andreabedini wants to merge 1 commit intohaskell:masterfrom
andreabedini wants to merge 1 commit intohaskell:masterfrom
Conversation
Remove the `traceTree` debugging utility and all associated `DEBUG_TRACETREE` CPP machinery from `Distribution.Solver.Modular.Solver`.
Collaborator
|
When I commented on #11179, I meant that I thought that there should be an issue for discussing removing the tracetree feature. Why does it need to be removed? It seems like a relatively small amount of code for a feature that some people have found useful for understanding the structure of the search tree. It is especially useful for parts of the tree that aren't shown in the -v3 log. |
Collaborator
Author
|
IMHO it is not useful in the current state. It's also code that never gets compiled so we have no idea if it even works. In any case, up to you. |
Collaborator
|
Why do you think that the tracetree feature isn't useful now? Is it because we stopped testing it in CI? I can open an issue for that. I'd rather keep it if it isn't too hard to update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
traceTreedebugging utility and all associatedDEBUG_TRACETREECPP machinery fromDistribution.Solver.Modular.Solver.