refactor(cabal-install-solver): remove workaround for bug closed years ago#11649
Open
andreabedini wants to merge 1 commit intohaskell:masterfrom
Open
refactor(cabal-install-solver): remove workaround for bug closed years ago#11649andreabedini wants to merge 1 commit intohaskell:masterfrom
andreabedini wants to merge 1 commit intohaskell:masterfrom
Conversation
ffaf1
approved these changes
Mar 24, 2026
philderbeast
approved these changes
Mar 24, 2026
sebright
approved these changes
Mar 25, 2026
Collaborator
sebright
left a comment
sebright
left a comment
There was a problem hiding this comment.
It looks like 8.0.2 is the earliest GHC that we're currently testing against in CI.
…s ago Replace the manual `Functor` instance on `Progress` with `deriving (Functor)`. The manual instance was a workaround for a GHC 7.6.3 space leak (https://gitlab.haskell.org/ghc/ghc/-/issues/7436), which has long been fixed.
andreabedini
force-pushed
the
refactor/progress-derive-functor
branch
from
e8900ab to
fc3b2c8
Compare
There was a problem hiding this comment.
Pull request overview
This PR modernizes Distribution.Solver.Types.Progress by removing an obsolete GHC 7.6.3-era workaround and using the standard derived Functor instance instead, aligning the code with current compiler behavior.
Changes:
- Added
DeriveFunctorlanguage pragma for the module. - Replaced the manual
Functor (Progress step fail)instance withderiving (Functor)onProgress.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the manual
Functorinstance onProgresswithderiving (Functor). The manual instance was a workaroundfor a GHC 7.6.3 space leak (https://gitlab.haskell.org/ghc/ghc/-/issues/7436), which has long been fixed.