data_source_job_parser: add variables support#582
Merged
vishnuedavarath merged 6 commits intomainfrom Mar 16, 2026
Merged
Conversation
Collaborator
Author
|
A gentle nudge on this @pkazmierczak |
pkazmierczak
previously approved these changes
Mar 13, 2026
Collaborator
pkazmierczak
left a comment
pkazmierczak
left a comment
There was a problem hiding this comment.
LGTM! Sorry for a delayed review, notification slipped through the cracks 😬
Add a `variables` parameter to pass HCL2 variables to the job parser. This allows users to parse job files that use variable blocks by providing variable values at parse time.
… nomad_job_parser
vishnuedavarath
force-pushed
the
f-vars-job-parse
branch
from
29060d4 to
9375ca4
Compare
Collaborator
Author
NP!😊 Needed to resolve a merge conflict, requesting approval again. |
pkazmierczak
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
variablesparameter to pass HCL2 variables to the job parser.This allows users to parse job files that use variable blocks by providing variable values at parse time.
Fixes #451
JIRA Ticket