list-resource/aws_vpc: Reduces API calls when listing#46935
Open
list-resource/aws_vpc: Reduces API calls when listing#46935
Conversation
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
github-actions
bot
added
prioritized
ewbankkit
added
technical-debt
jar-b
reviewed
Mar 16, 2026
Comment on lines
+2035
to
+2038
| results := make(map[string]*awstypes.RouteTable, len(output)) | ||
| for i, v := range output { | ||
| results[aws.ToString(v.VpcId)] = &output[i] | ||
| } |
Member
There was a problem hiding this comment.
This seems like it will overwrite the map entry for each route table in the result. Should this instead check for the key in result and append if already exists?
Edit: I see now the only current call to this function is from batchFindVPCMainRouteTables where we know the result will be limited to a single item per VPC, but it may still be worth future proofing should we reach for this in the future for batch listing all route tables and grouping by VPC.
Comment on lines
+2083
to
+2086
| results := make(map[string]*awstypes.SecurityGroup, len(output)) | ||
| for i, v := range output { | ||
| results[aws.ToString(v.VpcId)] = &output[i] | ||
| } |
Member
There was a problem hiding this comment.
Same for iterating security group results (multiple per VPC).
Comment on lines
+1871
to
+1874
| results := make(map[string]*awstypes.NetworkAcl, len(output)) | ||
| for i, v := range output { | ||
| results[aws.ToString(v.VpcId)] = &output[i] | ||
| } |
Member
There was a problem hiding this comment.
Same for iterating network ACLs (one per subnet, but a VPC may have multiple).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Reduces AWS API calls when listing by:
Relations
Closes #46724
Output from Acceptance Testing