Skip to content

r/aws_emrcontainers_job_template: Add parameter_configuration support#46933

Open
mark-liu wants to merge 2 commits intohashicorp:mainfrom
mark-liu:emrcontainers/parameter-configuration
Open

r/aws_emrcontainers_job_template: Add parameter_configuration support#46933
mark-liu wants to merge 2 commits intohashicorp:mainfrom
mark-liu:emrcontainers/parameter-configuration

Conversation

@mark-liu
Copy link

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes to security controls.

Description

The AWS SDK exposes ParameterConfiguration on JobTemplateData but the Terraform resource doesn't model it. Without this field, users can't define template parameters (referenced as ${ParameterName} placeholders) and StartJobRun with --job-template-parameters fails with "Parameter not defined".

This adds parameter_configuration as an optional TypeSet block under job_template_data with three attributes:

  • name — the parameter name (map key in the API)
  • typeSTRING or NUMBER (validated via enum.Validate)
  • default_value — optional default

Used TypeSet of blocks with a name key attribute since SDKv2 doesn't support maps of blocks natively. Same pattern as securityhub/configuration_policy.go.

Relations

Closes #46502

References

Output from Acceptance Testing

% make testacc TESTS=TestAccEMRContainersJobTemplate_parameterConfiguration PKG=emrcontainers

...

@mark-liu mark-liu requested a review from a team as a code owner March 13, 2026 23:04
@github-actions
Copy link
Contributor

Welcome @mark-liu 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider repository. Thank you very much for taking the time to do so, and welcome to the community! 🎉


Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. size/L Managed by automation to categorize the size of a PR. labels Mar 13, 2026
@mark-liu mark-liu closed this Mar 13, 2026
@dosubot dosubot bot added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 13, 2026
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Mar 13, 2026
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@mark-liu mark-liu reopened this Mar 13, 2026
Signed-off-by: Mark Liu <mark@prove.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EMR on EKS] aws_emrcontainers_job_template: add support for job_template_data.parameter_configuration

1 participant