r/aws_emrcontainers_job_template: Add parameter_configuration support#46933
r/aws_emrcontainers_job_template: Add parameter_configuration support#46933mark-liu wants to merge 2 commits intohashicorp:mainfrom
Conversation
Closes hashicorp#46502 Signed-off-by: Mark Liu <mark@prove.com.au>
|
Welcome @mark-liu 👋 It looks like this is your first Pull Request submission to the Terraform AWS Provider repository. Thank you very much for taking the time to do so, and welcome to the community! 🎉 Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
Signed-off-by: Mark Liu <mark@prove.com.au>
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
No changes to security controls.
Description
The AWS SDK exposes
ParameterConfigurationonJobTemplateDatabut the Terraform resource doesn't model it. Without this field, users can't define template parameters (referenced as${ParameterName}placeholders) andStartJobRunwith--job-template-parametersfails with "Parameter not defined".This adds
parameter_configurationas an optionalTypeSetblock underjob_template_datawith three attributes:name— the parameter name (map key in the API)type—STRINGorNUMBER(validated viaenum.Validate)default_value— optional defaultUsed
TypeSetof blocks with anamekey attribute since SDKv2 doesn't support maps of blocks natively. Same pattern assecurityhub/configuration_policy.go.Relations
Closes #46502
References
JobTemplateData.ParameterConfiguration—map[string]TemplateParameterConfiguration(already in sdk v1.40.15)Output from Acceptance Testing