Skip to content

d/aws_vpc multiple ipv6_cidr_block_associations#46918

Open
danquack wants to merge 4 commits intohashicorp:mainfrom
danquack:vpc-ipv6
Open

d/aws_vpc multiple ipv6_cidr_block_associations#46918
danquack wants to merge 4 commits intohashicorp:mainfrom
danquack:vpc-ipv6

Conversation

@danquack
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Allow of access to all ipv6_cidr_block_associations

Relations

Closes #44733

References

Output from Acceptance Testing

% make testacc TESTS=TestAccVPCDataSource_IPv6CIDRBlockAssociations_multiple PKG=ec2                
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 vpc-ipv6 🌿...
TF_ACC=1 go1.25.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCDataSource_IPv6CIDRBlockAssociations_multiple'  -timeout 360m -vet=off
2026/03/13 10:20:40 Creating Terraform AWS Provider (SDKv2-style)...
2026/03/13 10:20:40 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCDataSource_IPv6CIDRBlockAssociations_multiple
=== PAUSE TestAccVPCDataSource_IPv6CIDRBlockAssociations_multiple
=== CONT  TestAccVPCDataSource_IPv6CIDRBlockAssociations_multiple
--- PASS: TestAccVPCDataSource_IPv6CIDRBlockAssociations_multiple (55.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        61.243s

@danquack danquack requested a review from a team as a code owner March 13, 2026 14:24
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Mar 13, 2026
Type: schema.TypeString,
Computed: true,
Type: schema.TypeString,
Deprecated: "Use ipv6_cidr_block_associations instead",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is desired, but feel a user could get this by looking at the array themselves in future versions. Happy to remove these.

"ipv6_cidr_block_associations": {
Type: schema.TypeList,
Computed: true,
Elem: &schema.Resource{
Copy link
Contributor Author

@danquack danquack Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more fields, but I grabbed a copy of ipv4 associations to align. Notably missing:Attributes

@dosubot dosubot bot added the new-list-resource Introduces list resource support. label Mar 13, 2026
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. new-list-resource Introduces list resource support. labels Mar 13, 2026
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed new-data-source Introduces a new data source. labels Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

d/aws_vpc: ipv6_cidr_block_associations

2 participants