resource/aws_key_pair: fix public key import drift

[corymhall]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes to security controls.

Description

Fix aws_key_pair import so the provider reads and persists public_key after import.

This change:

• sets IncludePublicKey=true when reading a key pair by name
• stores the returned public_key in resource state during read
• normalizes OpenSSH public keys so state does not drift when AWS rewrites the key comment or trailing newline
• removes the stale import workaround from acceptance tests and adds explicit import coverage
• removes the stale documentation note that said the public key could not be returned by the API

Relations

Closes #44647

References

• Can't import public key when importing aws.KeyPair pulumi/pulumi-aws#5898

Output from Acceptance Testing

% make testacc TESTS='TestAccEC2KeyPair|TestAccEC2KeyPairDataSource' PKG=ec2

PASS
ok   github.com/hashicorp/terraform-provider-aws/internal/service/ec2  41.322s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.