Skip to content

fix: caching data - take two#2673

Draft
ericleponner wants to merge 4 commits intomainfrom
2521_caching_transactions_take2
Draft

fix: caching data - take two#2673
ericleponner wants to merge 4 commits intomainfrom
2521_caching_transactions_take2

Conversation

@ericleponner
Copy link
Copy Markdown
Contributor

Description:
Changes below

  • introduce new cache object AppCache which groups references to all other caches
  • replace injections of individual caches by AppCache injection
  • encapsulate TransactionBaseModel.computeSignatureKey() in AppCache.computeSignatureKey()
  • replace TransactionBaseModel.computeSignatureKey() invocations by AppCache.computeSignatureKey()

Related issue(s):

Another step for fixing #2521

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
…s/index.ts

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (cabb25d) to head (45fc9de).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2673   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         184      184           
  Lines        7447     7447           
  Branches     1493     1489    -4     
=======================================
  Hits         7444     7444           
  Misses          3        3           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant